This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
If an upload request is more than a day old then cancel it and retry #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These requests will always fail and will attempt to reauthenticate which will also fail.
|
Looks good I think. I just want to verify that this would catch any uploads that failed to send on previous versions of the sdk, correct? |
Yes, there's a different (more complicated) fix that would be needed to clear the upload request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These requests will always fail and will attempt to reauthenticate which will also fail.
@dephillipsmichael
This is a band-aid to attempt to clear the orphaned files and restart after an authentication failure.
I also added some additional logging.