This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
[iOS] Add a local schema to building of “answers.json” #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syoung-smallwisdom
requested review from
Erin-Mounts,
DwayneJengSage,
jnelsonjava and
nategbrown9
nategbrown9
reviewed
Sep 14, 2023
| case .array(let value): | ||
| return (value.map { "\($0)" }.joined(separator: ","), .string) | ||
| default: | ||
| return nil |
There was a problem hiding this comment.
This seems problematic to return nil for types not supported by the flatAnswer() function. Previously if we had a value it would get serialized into the answers file.
There was a problem hiding this comment.
Added "object" (though we don't actually have any currently supported question types that use this answer type).
Currently we do not have any examples but technically its allowed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty straight-forward to add the schema to the "answers.json" file on iOS. This was already supported as a part of Sage Research and we deprecated it b/c we were going away from data parsing and the researchers wanted timestamps and question text, etc. That model doesn't lend itself well to the flattened table. ¯_(ツ)_/¯