Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

DHP-973 airplane fetch #236

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

syoung-smallwisdom
Copy link
Collaborator

https://sagebionetworks.jira.com/browse/DHP-973

Don't try to get the assessment config as a flow.

Copy link
Contributor

@Erin-Mounts Erin-Mounts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise looks good I guess?

@@ -155,7 +155,7 @@ abstract class AbstractNativeTimelineManager(

fun fetchAssessmentConfig(instanceGuid: String, assessmentInfo: AssessmentInfo, callBack: (NativeAssessmentConfig) -> Unit) {
scope.launch {
assessmentConfigRepo.getAssessmentConfig(assessmentInfo).collectLatest { resource ->
val resource = assessmentConfigRepo.getAssessmentConfig(assessmentInfo)
val restoredResultData = localCache.loadData(instanceGuid, "AssessmentResult")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the indentation for this part need updating or is this a GitHub viewing artifact?

Copy link
Collaborator

@nategbrown9 nategbrown9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Unit Test Results

  33 files    33 suites   4s ⏱️
  78 tests   78 ✔️ 0 💤 0
117 runs  117 ✔️ 0 💤 0

Results for commit 92f0a2d.

♻️ This comment has been updated with latest results.

@syoung-smallwisdom syoung-smallwisdom merged commit 966da3f into main Oct 26, 2023
3 checks passed
@syoung-smallwisdom syoung-smallwisdom deleted the syoung/dhp-973-airplane-fetch branch February 27, 2024 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants