This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Fix DHP-1140: Add rest of adherence fields to upload metadata #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syoung-smallwisdom
suggested changes
Oct 30, 2023
syoung-smallwisdom
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Need to update the XCFramework binary before merging. There is a build configuration that you can use: createSwiftPackage
I think that we are creating tech debt here. Really, we should have an upload request take an optional AdherenceRecord object rather than "metadata" where the "metadata" is expected to match a subset of the AdherenceRecord properties. Just too many calls to services and too much room for typos. That said, I recognize that doing so is a more time-consuming refactor. ¯_(ツ)_/¯
...-client/src/commonMain/kotlin/org/sagebionetworks/bridge/kmm/shared/models/UploadMetadata.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.