This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Add ability to optionally store credentials for re-auth #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin-Mounts
approved these changes
Nov 6, 2023
| @@ -192,6 +193,21 @@ class AuthenticationRepository( | |||
| return signIn(signIn) | |||
| } | |||
|
|
|||
| private fun storeCredentials(password: String) { | |||
There was a problem hiding this comment.
You're only storing/retrieving the password and not the account-identifying credential (id, email, etc)? What am I missing here?
There was a problem hiding this comment.
reauthWithCredentials method uses the currently cached user session to get email or externalID.
There was a problem hiding this comment.
The reauthWithCredentials method is an existing method intended to restore the session token without striping the participant's data. In other words, it will only attempt to reauthenticate against the current email/externalId.
syoung-smallwisdom
approved these changes
Nov 6, 2023
...src/commonMain/kotlin/org/sagebionetworks/bridge/kmm/shared/repo/AuthenticationRepository.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.