This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Add more logging to the V1 file uploader #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin-Mounts
reviewed
Feb 16, 2024
SwiftPackage/Sources/BridgeClientExtension/File Uploading/V1/BridgeFileUploadManager.swift
Outdated
Show resolved
Hide resolved
| let fullPath = self.fullyQualifiedPath(of: filePath) | ||
| guard FileManager.default.fileExists(atPath: fullPath) else { | ||
| let message = "Unexpected: Attempting to retrieve upload API info for temp file with invariant path '\(filePath) but temp file does not exist at '\(fullPath)" | ||
| throw BridgeUnexpectedNullError(category: .missingFile, message: message) | ||
| } | ||
| let tempFile = URL(fileURLWithPath: fullPath) | ||
| let attributes = try? FileManager.default.attributesOfItem(atPath: fullPath) |
There was a problem hiding this comment.
I'm not 100% certain, but I don't think this gets extended attributes, if that's what you were hoping to log. There's a completely separate api for xattrs. IIRC there's a class extension somewhere that implements this since I think xattrs api is Obj-C only.
There was a problem hiding this comment.
yeah, I'm looking for the attributes like "when was the file last modified/created" rather than the extended attributes.
syoung-smallwisdom
force-pushed
the
syoung/orphan-upload-logging
branch
from
a5d68f8
to
969b5c9
Compare
This was trying to process files that were being stored by the app in app support at the base directory.
Erin-Mounts
approved these changes
Feb 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashlytics is reporting that the V1 uploader is attempting to repeatedly upload an orphaned file with no attributes.
The device in question successfully uploaded the three files, but it looks like they were left behind and not deleted. I'm adding some additional logging to see if there is some pattern I can use to successfully mark the files as uploaded and delete them.
I figured out that files were being stored in the base directory of the "Application Support" directory and the uploader was counting those as orphaned files rather than skipping them.