Define AppConfigDescriptor with JSON instead of string #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
commented
Aug 15, 2024
Comment on lines
+6
to
+20
| "appConfigDefaultConfiguration": { | ||
| "GOOGLE_MAP": false, | ||
| "VIEW_ASSOCIATED_PROJECTS": false, | ||
| "PROVENANCE_DOCKER_IMAGES": false, | ||
| "JSONSCHEMA_VALIDATION_STATUS": false, | ||
| "DESCRIPTION_FIELD": false, | ||
| "ADD_WIKI_WIDGETS": false, | ||
| "WIKI_DIFF_TOOL": false, | ||
| "CUSTOM_STORAGE_LOCATION_SETTINGS": false, | ||
| "CHALLENGE_SUBMISSION_SETTINGS": false, | ||
| "PROVENANCE_V2_VISUALIZATION": true, | ||
| "VIRTUALTABLE_SUPPORT": false, | ||
| "SRC_BASED_AR_MODAL_WIZARD": false, | ||
| "REACT_ENTITY_ACL_EDITOR": true | ||
| } |
There was a problem hiding this comment.
Now this must be JSON
nickgros
commented
Aug 15, 2024
| @@ -35,7 +35,7 @@ | |||
| "Ref": "dev101portalAppConfigConfigProfile" | |||
| }, | |||
| "Description": "Freeform config for toggling experimental mode features", | |||
| "Content": "{\"GOOGLE_MAP\": false, \"VIEW_ASSOCIATED_PROJECTS\": false, \"PROVENANCE_DOCKER_IMAGES\": false, \"JSONSCHEMA_VALIDATION_STATUS\": false, \"DESCRIPTION_FIELD\": false, \"ADD_WIKI_WIDGETS\": false, \"WIKI_DIFF_TOOL\": false, \"CUSTOM_STORAGE_LOCATION_SETTINGS\": false, \"CHALLENGE_SUBMISSION_SETTINGS\": false, \"PROVENANCE_V2_VISUALIZATION\": true, \"VIRTUALTABLE_SUPPORT\": false, \"SRC_BASED_AR_MODAL_WIZARD\": false, \"REACT_ENTITY_ACL_EDITOR\": true}", | |||
There was a problem hiding this comment.
Had to remove spaces because those are lost on serialization
nickgros
commented
Aug 15, 2024
Comment on lines
27
to
32
| ObjectMapper mapper = new ObjectMapper(); | ||
| try { | ||
| this.appConfigDefaultConfiguration = mapper.writeValueAsString(mapper.writeValueAsString(appConfigDefaultConfiguration)); | ||
| } catch (JsonProcessingException e) { | ||
| throw new IllegalArgumentException("Failed to serialize appConfigDefaultConfiguration", e); | ||
| } |
There was a problem hiding this comment.
We still need to pass a string to CloudFormation, so use Jackson to serialize the object to a string twice, which will give us properly-escaped stringified JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.