Merge pull request #5418 from Sage-Bionetworks/release-501

merge release 501 into develop
Sage-Bionetworks · Jun 6, 2024 · 200d69e · 200d69e
2 parents 3a9bc52 + b4d4b37
commit 200d69e
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/src/main/java/org/sagebionetworks/web/client/GWTWrapperImpl.java b/src/main/java/org/sagebionetworks/web/client/GWTWrapperImpl.java
@@ -34,7 +34,7 @@ public class GWTWrapperImpl implements GWTWrapper {
 
   @Override
   public String getHostPageBaseURL() {
-    return GWT.getHostPageBaseURL();
+    return getHostpageUrl();
   }
 
   @Override

diff --git a/src/main/java/org/sagebionetworks/web/client/widget/entity/EntityBadge.java b/src/main/java/org/sagebionetworks/web/client/widget/entity/EntityBadge.java
@@ -215,7 +215,7 @@ public void onFailure(Throwable caught) {
         }
 
         public void onSuccess(AddBatchOfFilesToDownloadListResponse result) {
-          String href = "DownloadCart:0";
+          String href = "/DownloadCart:0";
           popupUtils.showInfo(
             entityHeader.getName() + EntityBadge.ADDED_TO_DOWNLOAD_LIST,
             href,

diff --git a/src/main/java/org/sagebionetworks/web/client/widget/entity/EntityListRowBadge.java b/src/main/java/org/sagebionetworks/web/client/widget/entity/EntityListRowBadge.java
@@ -219,7 +219,7 @@ public void onFailure(Throwable caught) {
         }
 
         public void onSuccess(AddBatchOfFilesToDownloadListResponse result) {
-          String href = "DownloadCart:0";
+          String href = "/DownloadCart:0";
           popupUtils.showInfo(
             entityName + EntityBadge.ADDED_TO_DOWNLOAD_LIST,
             href,

diff --git a/.../java/org/sagebionetworks/web/client/widget/entity/renderer/ButtonLinkWidgetViewImpl.java b/.../java/org/sagebionetworks/web/client/widget/entity/renderer/ButtonLinkWidgetViewImpl.java
@@ -70,13 +70,17 @@ public ButtonLinkWidgetViewImpl(
   public void configure(
     WikiPageKey wikiKey,
     String buttonText,
-    final String url,
+    String url,
     boolean isHighlight,
     final boolean openInNewWindow
   ) {
     clear();
     button.setText(buttonText);
     if (isHighlight) button.setType(ButtonType.INFO);
+    // Detect old #!, and direct to the right place
+    if (url.startsWith("#!")) {
+      url = "/" + url.substring("#!".length());
+    }
     button.setHref(url);
     if (openInNewWindow) {
       button

diff --git a/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/EntityBadgeTest.java b/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/EntityBadgeTest.java
@@ -363,7 +363,7 @@ public void testOnAddToDownloadListV2() {
     verify(mockPopupUtils)
       .showInfo(
         header.getName() + EntityBadge.ADDED_TO_DOWNLOAD_LIST,
-        "DownloadCart:0",
+        "/DownloadCart:0",
         DisplayConstants.VIEW_DOWNLOAD_LIST
       );
     verify(mockEventBus).fireEvent(any(DownloadListUpdatedEvent.class));

diff --git a/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/EntityListRowBadgeTest.java b/src/test/java/org/sagebionetworks/web/unitclient/widget/entity/EntityListRowBadgeTest.java
@@ -286,7 +286,7 @@ public void testOnAddToDownloadListV2() {
     verify(mockPopupUtils)
       .showInfo(
         entityName + EntityBadge.ADDED_TO_DOWNLOAD_LIST,
-        "DownloadCart:0",
+        "/DownloadCart:0",
         DisplayConstants.VIEW_DOWNLOAD_LIST
       );
     verify(mockEventBus).fireEvent(any(DownloadListUpdatedEvent.class));