SWC-6556: add end-to-end test for file CRUD #5207
Conversation
| await testAuth.step('file page is loaded', async () => { | ||
| await page.waitForURL(entityUrlPathname(fileEntityId)) | ||
| await expect(page.getByText(`Discussion about ${fileName}`)).toBeVisible() | ||
|
|
||
| await expect(page.getByText('Loading provenance...')).not.toBeVisible() | ||
| await expect(page.getByText(fileEntityId, { exact: true })).toBeVisible() | ||
| await expect(page.getByText('Loading provenance...')).not.toBeVisible() | ||
| await expect(page.getByText(fileEntityId, { exact: true })).toBeVisible() | ||
| }) |
There was a problem hiding this comment.
Moved this check into its own step, so the Playwright reports are a bit tidier
| const confirmAndClosePermissionsSavedAlert = async (page: Page) => { | ||
| const permissionsAlert = page.getByRole('alert').filter({ | ||
| has: page.getByText('Permissions were successfully saved to Synapse'), | ||
| }) | ||
| await expect(permissionsAlert).toBeVisible() | ||
| await permissionsAlert.getByRole('button').click() | ||
| await expect(permissionsAlert).not.toBeVisible() | ||
| } |
There was a problem hiding this comment.
Pulled this into a new method (dismissAlert), so it can be reused across tests
| await testAuth.step('ensure there was not an upload error', async () => { | ||
| await expect( | ||
| page.getByRole('heading', { name: 'Upload Error' }), | ||
| ).not.toBeVisible() | ||
| }) |
There was a problem hiding this comment.
Useful for distinguishing between a file upload timeout vs a file upload error when debugging a failed test in CI.
| test.fail( | ||
| browserName === 'webkit', | ||
| `Playwright is not preserving the File's lastModified time in webkit, so | ||
| file upload fails because it seems like the file was modified during | ||
| upload. See https://github.com/microsoft/playwright/issues/27452. Fix | ||
| planned for Playwright v1.40.`, | ||
| ) |
There was a problem hiding this comment.
In webkit, Playwright uses the current time for the lastModified time, rather than preserving the value on the File. Test marked as failed until the fixed version is released, likely in mid-November.
There was a problem hiding this comment.
This webkit engine is just causing all sorts of problems!
| await testAuth.step('move file to trash can', async () => { | ||
| await testAuth.step('delete file', async () => { |
There was a problem hiding this comment.
Playwright steps can be nested, which makes reports a bit easier to read
| @@ -11,7 +11,7 @@ export type UserPrefixes = (typeof userPrefixes)[number] | |||
| const generateUserName = (prefix: string) => { | |||
| // uncomment to use static username for troubleshooting: | |||
| // ...and ensure that usernames are unique per worker | |||
| // return `${prefix}-${process.env.TEST_PARALLEL_INDEX}` | |||
| // return `local-${prefix}-${process.env.TEST_PARALLEL_INDEX}` | |||
There was a problem hiding this comment.
In local tests using static usernames, the lingering test users on the backend dev stack caused multiple users to appear in the user suggestion dropdown, when we expect one user to appear (e.g. swc-e2e-user-validated-0 and swc-e2e-user-validated-0d930519-5c31-4137-9def-8fe9ea483f22). Add a prefix for local testing, so that the local static test users are easily selected.
| first,second,third | ||
| 1,one,true | ||
| 2,two,false | ||
| 3,three,true |
There was a problem hiding this comment.
Create static files that can be uploaded via the FileChooser
No description provided.