-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETL-535] Set up SQS to receive S3 event notification #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes requested.
Description: Arn for the S3 Event Config Lambda Function | ||
Description: Arn for the S3 Event Config Destination | ||
|
||
S3ToGlueDestinationType: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add an AllowedValues
property to this.
@@ -0,0 +1,13 @@ | |||
template: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want an analogous config file in config/prod
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise for the s3-event-config-lambda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess when I originally created this PR, I wasn't sure if we were going to push this right away or leave it in dev branch to avoid messing with production. Based on our recent discussion, it seems like we should be okay to also have it in prod so will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. It will exist independently of everything else for now. We do modify the behavior of the event config lambda, but we aren't using it right now so it shouldn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Excellent @rxu17 ! Also great review @philerooski !
Purpose: This PR contains initial work done as part of ETL-532 which led us to move forward with using SQS queue.
This PR only does the following: