remove redundant stylings already defined in main scss; lint

Sage-Bionetworks · Dec 19, 2024 · 395b8f5 · 395b8f5
1 parent 2759366
commit 395b8f5
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 19 deletions.
diff --git a/libs/openchallenges/challenge/src/lib/_challenge-theme.scss b/libs/openchallenges/challenge/src/lib/_challenge-theme.scss
@@ -11,31 +11,39 @@
   .base {
     background-color: white;
   }
+
   #profile-top,
   #profile-stats {
     border-color: transparent;
     background-color: map.get($figma, dl-color-default-hover1);
   }
+
   .featured {
     border-color: transparent;
     color: #71c663;
   }
+
   .username {
     color: map.get($figma, dl-color-default-secondary1);
   }
+
   .profile-nav-group {
     border-color: map.get($figma, dl-color-default-primary2);
-    background-color: rgba(255, 255, 255, 1);
+    background-color: rgb(255 255 255 / 100%);
   }
+
   .profile-nav-item {
     border-color: transparent;
+
     &:focus,
     &:hover {
       background-color: map.get($figma, dl-color-default-primary1);
       color: white;
     }
+
     color: black;
   }
+
   .profile-nav-item.active-tab {
     background-color: map.get($figma, dl-color-default-navbardark);
     color: white;
@@ -60,11 +68,7 @@
     }
   }
 
-  .text-grey {
-    color: rgba(black, 0.38);
-  }
-
-  @media (max-width: 479px) {
+  @media (width <= 479px) {
     .profile-pic {
       background-color: map.get($figma, dl-color-default-hover2);
     }
@@ -75,18 +79,22 @@
   .username {
     font-size: 28px;
   }
+
   .profile-featured > .mat-icon {
     font-size: 60px;
   }
+
   .profile-pic {
     div.avatar-content {
-      font-family: 'Lato', sans-serif !important;
+      font-family: Lato, sans-serif !important;
     }
   }
-  @media screen and (max-width: 641px) {
+
+  @media screen and (width <= 641px) {
     #profile-details > h2 {
       font-size: 32px;
     }
+
     #profile-details > h3 {
       font-size: 21px;
     }
@@ -95,12 +103,14 @@
 
 @mixin theme($theme) {
   $color-config: mat.m2-get-color-config($theme);
-  @if $color-config != null {
+
+  @if $color-config {
     @include color($theme);
   }
 
   $typography-config: mat.m2-get-typography-config($theme);
-  @if $typography-config != null {
+
+  @if $typography-config {
     @include typography($theme);
   }
 }
diff --git a/libs/openchallenges/org-profile/src/lib/_org-profile-theme.scss b/libs/openchallenges/org-profile/src/lib/_org-profile-theme.scss
@@ -11,44 +11,50 @@
   .base {
     background-color: white;
   }
+
   #profile-top,
   #profile-stats {
     border-color: transparent;
     background-color: map.get($figma, dl-color-default-hover1);
   }
+
   .verified {
     border-color: transparent;
     color: map.get($figma, dl-color-default-darkaccent1);
   }
+
   .username {
     color: map.get($figma, dl-color-default-secondary1);
   }
+
   .profile-type {
     border-color: map.get($figma, dl-color-default-secondary2);
     background-color: map.get($figma, dl-color-default-accent2);
   }
+
   .profile-nav-group {
     border-color: map.get($figma, dl-color-default-primary2);
-    background-color: rgba(255, 255, 255, 1);
+    background-color: rgb(255 255 255 / 100%);
   }
+
   .profile-nav-item {
     border-color: transparent;
+
     &:focus,
     &:hover {
       background-color: map.get($figma, dl-color-default-primary1);
       color: white;
     }
+
     color: black;
   }
+
   .profile-nav-item.active-tab {
     background-color: map.get($figma, dl-color-default-navbardark);
     color: white;
   }
-  .text-grey {
-    color: rgba(black, 0.38);
-  }
 
-  @media (max-width: 479px) {
+  @media (width <= 479px) {
     .profile-pic {
       background-color: map.get($figma, dl-color-default-hover2);
     }
@@ -59,15 +65,18 @@
   .username {
     font-size: 28px;
   }
+
   .profile-pic {
     div.avatar-content {
-      font-family: 'Lato', sans-serif !important;
+      font-family: Lato, sans-serif !important;
     }
   }
-  @media screen and (max-width: 641px) {
+
+  @media screen and (width <= 641px) {
     #profile-details > h2 {
       font-size: 32px;
     }
+
     #profile-details > h3 {
       font-size: 21px;
     }
@@ -76,12 +85,14 @@
 
 @mixin theme($theme) {
   $color-config: mat.m2-get-color-config($theme);
-  @if $color-config != null {
+
+  @if $color-config {
     @include color($theme);
   }
 
   $typography-config: mat.m2-get-typography-config($theme);
-  @if $typography-config != null {
+
+  @if $typography-config {
     @include typography($theme);
   }
 }