Skip to content

Commit

Permalink
moving github tag logic into config
Browse files Browse the repository at this point in the history
  • Loading branch information
sagely1 committed Jan 5, 2025
1 parent 5eaf8ab commit 9bb4a68
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion apps/agora/app/src/config/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"appVersion": "4.0.0",
"csrApiUrl": "http://localhost:3333/v1",
"ssrApiUrl": "http://agora-api:3333/v1",
"rollbarToken": "e788198867474855a996485580b08d03"
"rollbarToken": "e788198867474855a996485580b08d03",
"tagName": "agora/v0.0.2"
}
3 changes: 2 additions & 1 deletion apps/agora/app/src/config/config.json.template
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"appVersion": "${APP_VERSION}",
"csrApiUrl": "${CSR_API_URL}",
"ssrApiUrl": "${SSR_API_URL}",
"rollbarToken": "${ROLLBAR_TOKEN}"
"rollbarToken": "${ROLLBAR_TOKEN}",
"tagName": "${TAG_NAME}"
}
1 change: 1 addition & 0 deletions libs/agora/config/src/lib/app.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export interface AppConfig {
ssrApiUrl: string;
apiDocsUrl: string;
rollbarToken: string;
tagName: string;
}

export const EMPTY_APP_CONFIG = {} as AppConfig;
3 changes: 2 additions & 1 deletion libs/agora/ui/src/lib/components/footer/footer.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class FooterComponent implements OnInit {
dataVersion$!: Observable<Dataversion>;
sha$!: Observable<string>;

tag = 'agora/v0.0.2';
tag = '';

navItems: Array<NavigationLink> = [
{
Expand All @@ -48,6 +48,7 @@ export class FooterComponent implements OnInit {

constructor() {
this.footerLogoPath = this.sanitizer.sanitize('/agora-assets/images/footer-logo.svg');
this.tag = this.configService.config.tagName;
}

ngOnInit(): void {
Expand Down

0 comments on commit 9bb4a68

Please sign in to comment.