-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): Convert profile pages to single-page layout #1946
Conversation
A nice-to-have would be to change the active state of the TOC based on scroll, but maybe this can be saved for another PR? I found this component that we could use in-place of the TOC we implemented, which will have the scrolling active states. It just hasn't been maintained in a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice-to-have would be to change the active state of the TOC based on scroll, but maybe this can be saved for another PR?
The current implementation would likely confuse users and prompt users to report a bug.
I found this component that we could use in-place of the TOC we implemented, which will have the scrolling active states. It just hasn't been maintained in a while.
This package offers what we need, but it relies an a largely outdated version of Angular (> 2 years). If no alternative to this package can be found, we could add the code of the package mentioned above to our code base and update it so that it depends on the version of Angular used in the monorepo. There isn't much code to import so that looks reasonable to me.
How to manage paginated content like Stargazers?
We should ideally clarify this design question before moving to single-page layout. If no paginated content is expected to be added within 6 months, then it may be fine to move ahead with the single-page layout.
I thought @rrchai had suggested a plan on how we would handle the stargazers content? But I can convert this to a draft in the meantime. |
There's been a lot of changes since this was opened. Will close this for now; we can revisit this if/when we decide to change the layout. |
Fixes #1833
Changelog
Preview
Challenge Profile, e.g.