Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Convert profile pages to single-page layout #1946

Closed
wants to merge 22 commits into from

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Aug 7, 2023

Fixes #1833

Changelog

  • Remove tabs
  • Move all contents into a single page
  • Sticky the TOC once scrolled

Preview

Challenge Profile, e.g.
single-page-layout

@vpchung vpchung self-assigned this Aug 7, 2023
@vpchung
Copy link
Member Author

vpchung commented Aug 9, 2023

A nice-to-have would be to change the active state of the TOC based on scroll, but maybe this can be saved for another PR?

I found this component that we could use in-place of the TOC we implemented, which will have the scrolling active states. It just hasn't been maintained in a while.

@vpchung vpchung marked this pull request as ready for review August 9, 2023 08:23
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice-to-have would be to change the active state of the TOC based on scroll, but maybe this can be saved for another PR?

The current implementation would likely confuse users and prompt users to report a bug.

I found this component that we could use in-place of the TOC we implemented, which will have the scrolling active states. It just hasn't been maintained in a while.

This package offers what we need, but it relies an a largely outdated version of Angular (> 2 years). If no alternative to this package can be found, we could add the code of the package mentioned above to our code base and update it so that it depends on the version of Angular used in the monorepo. There isn't much code to import so that looks reasonable to me.

How to manage paginated content like Stargazers?

We should ideally clarify this design question before moving to single-page layout. If no paginated content is expected to be added within 6 months, then it may be fine to move ahead with the single-page layout.

@vpchung
Copy link
Member Author

vpchung commented Aug 21, 2023

How to manage paginated content like Stargazers?

I thought @rrchai had suggested a plan on how we would handle the stargazers content? But I can convert this to a draft in the meantime.

@vpchung vpchung marked this pull request as draft August 21, 2023 18:02
@vpchung
Copy link
Member Author

vpchung commented Nov 22, 2023

There's been a lot of changes since this was opened.

Will close this for now; we can revisit this if/when we decide to change the layout.

@vpchung vpchung closed this Nov 22, 2023
@vpchung vpchung deleted the enhance-1833 branch November 22, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Switch to one-page layout for Profile pages
2 participants