-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add platform logos to landing page #2148
Conversation
@vpchung You should create a new component instead of "hijacking" the home-organization component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I would prefer to keep the "Discover Organizations" as it is now.
- The new Platform section should have a title that match the size of the title of "Discover Organizations" (no need for sub-titles)
Option ASection titles only Option BSection title with organization short summary Option CSection title with both short summaries |
Option C looks good to me - some explanations for user can't go wrong in my opinion. Maybe not showcasing the total number of platforms "12" here, instead using "various/multiple" or other alternatives, because it may not seem a big number for users who don't know challenge platforms. |
Thank you both for the feedback! I took both of your suggestions and compromised with the following:
|
Thanks for checking, @rrchai ! Is that what the image looks like on your end....? 😮 It doesn't look like this?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see how the entire Platform section looks like right now (section title + logo). Here is my feedback based on what I remember seeing during our 1:1.
If I remember correctly, the vertical space A between the title and the first row of logos is smaller than the vertical space B between rows of logos. Similarly to previous feedback, the layout would be better structured IMO if the section title was one "element" and the logos were a second "element". To achieve this, the vertical space A should be larger than B.
@tschaffter @rrchai I decreased the vertical padding between the frames to 5px, as well as added more padding between the image and text: |
libs/openchallenges/home/src/lib/platforms/platforms.component.html
Outdated
Show resolved
Hide resolved
@tschaffter Thanks for the suggestion! Here is the updated description: EDIT: Hmm... the text and image are not aligned in the center for some reason... investigating further. |
Fixes #2144
Changelog
add "Platforms" section
add list of platform logos (Figma mockup here)
update number of platforms in the metrics section from 16 to 12; we will not be counting:
update wording so there's a better story (see Preview)
Preview