Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add platform logos to landing page #2148

Merged
merged 24 commits into from
Oct 2, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Sep 22, 2023

Fixes #2144

Changelog

  • add "Platforms" section

  • add list of platform logos (Figma mockup here)

    [!NOTE]
    platforms are listed in alphabetical order, as to not show favoritism

  • update number of platforms in the metrics section from 16 to 12; we will not be counting:

    • "CASP" (@gaiaandreoletti and I concluded that this is more technically an organization rather than a platform)
    • "Other"
    • "OpenML" or "Papers With Code" (not challenge-hosting platforms)
  • update wording so there's a better story (see Preview)

Preview

Screenshot 2023-09-28 at 4 59 10 PM

@vpchung vpchung self-assigned this Sep 22, 2023
@tschaffter
Copy link
Member

tschaffter commented Sep 22, 2023

@vpchung You should create a new component instead of "hijacking" the home-organization component.

@vpchung vpchung marked this pull request as ready for review September 28, 2023 21:09
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I would prefer to keep the "Discover Organizations" as it is now.
  • The new Platform section should have a title that match the size of the title of "Discover Organizations" (no need for sub-titles)

libs/openchallenges/assets/src/assets/images/platforms.svg Outdated Show resolved Hide resolved
@vpchung
Copy link
Member Author

vpchung commented Sep 29, 2023

@tschaffter : I would prefer to keep the "Discover Organizations" as it is now.

Option A

Section titles only

Screenshot 2023-09-28 at 8 40 26 PM

Option B

Section title with organization short summary

Screenshot 2023-09-28 at 8 43 42 PM

Option C

Section title with both short summaries

Screenshot 2023-09-28 at 8 47 11 PM

@rrchai
Copy link
Contributor

rrchai commented Sep 29, 2023

Option C looks good to me - some explanations for user can't go wrong in my opinion.

Maybe not showcasing the total number of platforms "12" here, instead using "various/multiple" or other alternatives, because it may not seem a big number for users who don't know challenge platforms.

@vpchung
Copy link
Member Author

vpchung commented Sep 29, 2023

Thank you both for the feedback! I took both of your suggestions and compromised with the following:

Screenshot 2023-09-29 at 11 07 07 AM

Merging now~
@tschaffter @rrchai does the image of platforms display in your workspace? The image service is broken on my end again, so I'm not able to test on my end.

@vpchung vpchung requested a review from tschaffter September 29, 2023 22:57
@rrchai
Copy link
Contributor

rrchai commented Oct 2, 2023

@vpchung

The platform image looks like this on my end:

Screen Shot 2023-10-02 at 10 53 07 AM

@vpchung
Copy link
Member Author

vpchung commented Oct 2, 2023

Thanks for checking, @rrchai ! Is that what the image looks like on your end....? 😮 It doesn't look like this?

platforms

@tschaffter whenever you have time, can you review the PR again? I'm not able to merge until you approve.

Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see how the entire Platform section looks like right now (section title + logo). Here is my feedback based on what I remember seeing during our 1:1.

If I remember correctly, the vertical space A between the title and the first row of logos is smaller than the vertical space B between rows of logos. Similarly to previous feedback, the layout would be better structured IMO if the section title was one "element" and the logos were a second "element". To achieve this, the vertical space A should be larger than B.

@vpchung
Copy link
Member Author

vpchung commented Oct 2, 2023

@tschaffter @rrchai I decreased the vertical padding between the frames to 5px, as well as added more padding between the image and text:

Screenshot 2023-10-02 at 10 47 17 AM

@tschaffter tschaffter self-requested a review October 2, 2023 18:05
@vpchung
Copy link
Member Author

vpchung commented Oct 2, 2023

@tschaffter Thanks for the suggestion! Here is the updated description:

Screenshot 2023-10-02 at 11 23 36 AM

EDIT: Hmm... the text and image are not aligned in the center for some reason... investigating further.

@vpchung
Copy link
Member Author

vpchung commented Oct 2, 2023

Fixed:

Screenshot 2023-10-02 at 11 32 57 AM

@tschaffter tschaffter self-requested a review October 2, 2023 19:52
@vpchung vpchung merged commit 45b5a7d into Sage-Bionetworks:main Oct 2, 2023
@vpchung vpchung deleted the story-2144 branch October 2, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story] Introduce challenge platforms on the OC Home page
3 participants