fix(openchallenges): use default text for empty start/end dates #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaffter
requested changes
Oct 9, 2023
libs/openchallenges/challenge/src/lib/challenge-overview/challenge-overview.component.ts
Outdated
Show resolved
Hide resolved
libs/openchallenges/challenge/src/lib/challenge-overview/challenge-overview.component.ts
Outdated
Show resolved
Hide resolved
vpchung
changed the title
tschaffter
requested changes
Oct 13, 2023
libs/openchallenges/challenge/src/lib/challenge-overview/challenge-overview.component.ts
Outdated
Show resolved
Hide resolved
tschaffter
reviewed
Oct 13, 2023
| @@ -1,7 +1,7 @@ | |||
| <main *ngIf="challenge"> | |||
| <div id="bio"> | |||
| <h3 class="top-section-title">Overview</h3> | |||
| <p>{{ useNaIfEmpty(challenge.description) }}</p> | |||
| <p>{{ useNaIfFalsey(challenge.description) }}</p> | |||
There was a problem hiding this comment.
Don't US speakers always adopt the shortest words? ;-)
A falsy (sometimes written falsey) value is a value that is considered false when encountered in a Boolean context.
Source: https://developer.mozilla.org/en-US/docs/Glossary/Falsy
tschaffter
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2130
Changelog
use_default()str == null(instead ofstr === null || str === undefined) since this expression will return false for undefined values as welltext-grayclass for Start Date and End Date if date not availablePreview
Just in case, I also checked the organization profile to ensure the latest logic change doesn't affect existing default texts:
