Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openchallenges): move OC API docs URL to app config #2230

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Oct 13, 2023

Fixes #2219

Changelog

  • Add new variable (API_DOCS_URL) to openchallenges-app env file
  • Add new variable (apiDocsUrl) to openchallenges-app config.json and config.template.json
  • Update HTML and TS files that display the footer so that the API docs URL used is dependent on where the app is deployed

Preview

Local deployment:
Screenshot 2023-10-13 at 11 16 04 AM

@tschaffter tschaffter changed the title fix(openchallenges): move OC domains to app config fix(openchallenges): move OC API docs URL to app config Oct 13, 2023
@tschaffter
Copy link
Member

I changed the title of the ticket and PR to reflect that the scope is limited to externalizing the API docs URL and not the entire OC web app domain as initially described in the ticket.

@vpchung vpchung merged commit 6b7f7ac into Sage-Bionetworks:main Oct 14, 2023
7 checks passed
@vpchung vpchung deleted the bug-2219 branch October 14, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add OC API docs URL to the app config file
2 participants