Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): update team page #2248

Merged
merged 8 commits into from
Oct 27, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Oct 19, 2023

Fixes #2197

Changelog

  • Add Gaia to the team page (@gaiaandreoletti has already approved the displayed role)
  • Add a kudos shoutout to our Design and Governance team
  • Add Sage Bionetworks logo (as suggested by Luca)

Note

Given the recent change to the CI workflow (and increased cost), the commits for adding the kudos and Sage logo has not yet been pushed. Once a design is approved, I will push the missing commits, then merge.

Preview

Option 1

Sage logo at the top, under the team description.
Screenshot 2023-10-18 at 5 48 07 PM

Option 2

Remove team description, Sage logo at the bottom (under the kudos)
Screenshot 2023-10-18 at 5 47 18 PM

@vpchung vpchung self-assigned this Oct 19, 2023
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Order the members as follow (roughly by start date; we can revise this order in 6 mo)
    • Thomas, Verena, Rong, Maria, Gaia, Jake
  • We may end up adding Sage logo to the navbar, in which case adding Sage logo below the team members would be preferable to put some distance between the two logos.
  • What is the motivation for removing the team description?

@vpchung
Copy link
Member Author

vpchung commented Oct 19, 2023

What is the motivation for removing the team description?

It's a fun description, but I don't know if it adds enough... value? I think if we were to display the Sage logo, we should ideally mention that instead.

@tschaffter
Copy link
Member

The pics on the team pages looks pixelated. An additional task for this PR is to replace them with high-res versions. Could this be the result of Thumbor's processing?

@vpchung
Copy link
Member Author

vpchung commented Oct 26, 2023

Latest iteration:

Screenshot 2023-10-26 at 1 13 29 AM

@rrchai
Copy link
Contributor

rrchai commented Oct 26, 2023

Look good to me overall, but I suggest to use same font size and font weight for both "Meet... " and "We're smart...".

Screen Shot 2023-10-26 at 10 08 37 AM

@vpchung
Copy link
Member Author

vpchung commented Oct 26, 2023

use same font size and font weight for both "Meet... " and "We're smart...".

Oh, I didn't like how it looked when they were the same size, which is why I changed it. But can switch back if that is the majority opinion.

@vpchung
Copy link
Member Author

vpchung commented Oct 27, 2023

Latest iteration:

Screenshot 2023-10-27 at 2 10 37 PM

@tschaffter tschaffter self-requested a review October 27, 2023 21:29
@vpchung vpchung merged commit e442eeb into Sage-Bionetworks:main Oct 27, 2023
6 checks passed
@vpchung vpchung deleted the feat-2197 branch October 27, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Gaia to the OC Team page
3 participants