Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): add new operation property to Challenge schema #2264

Closed
wants to merge 17 commits into from

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Oct 22, 2023

Changelog

  • Add operation_id to Challenge data model
  • Regenerate API spec + Java files
  • Add operation_id to challenges table in DB
  • Include operation in CSV dump file for challenges
  • Update db-update script to include operation_id into the CSV dump
  • Add EDAM Operation Class to challenge profile, but I think there is a bug (see this comment)

Preview

challenges table
Screenshot 2024-02-16 at 4 49 18 PM

API docs
Screenshot 2024-02-16 at 4 49 40 PM

Screenshot 2024-02-16 at 4 49 50 PM

Challenge profile
Screenshot 2024-02-19 at 11 04 34 PM

@vpchung vpchung self-assigned this Oct 22, 2023
@vpchung vpchung marked this pull request as ready for review October 24, 2023 22:58
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to the other PR, but 0 should not be a valid operation (ID).

@vpchung
Copy link
Member Author

vpchung commented Feb 17, 2024

2024 update:

  • operation is now operation_id

Screenshot 2024-02-16 at 4 49 18 PM

Screenshot 2024-02-16 at 4 49 40 PM

Screenshot 2024-02-16 at 4 49 50 PM

  • automated script that dumps the CSV files has been updated to include operation_id into the dump

  • I started adding the operation class to the challenge profile:

           <td class="text-right">EDAM Operation Class</td>
           <td [ngClass]="{ 'text-grey': challenge.operationId === null }">
             {{ useNaIfFalsey(challenge.operationId) }}
           </td>
    

    but I think some updates to the REST API is needed before I can use challenge.operationId.

@vpchung vpchung added angular sonar-scan-approved-deprecated Ready for Sonar code analysis and removed angular labels Feb 17, 2024
@vpchung vpchung requested a review from tschaffter February 17, 2024 00:53
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first comment in the thread should be updated as it includes deprecated information.

Have we discussed how the operation ID is going to be used? I can then implement the necessary changes to the challenge service.

@vpchung
Copy link
Member Author

vpchung commented Feb 19, 2024

Have we discussed how the operation ID is going to be used? I can then implement the necessary changes to the challenge service.

I mentioned on Friday that I plan to add it to the profile for now - I think that will be the easiest win. I can also see it as a search option.

@vpchung
Copy link
Member Author

vpchung commented Feb 20, 2024

Remaining TODO (maybe save for another PR?)

After updating the Angular CLI client, I was able to use challenge.operation_id on the frontend; "EDAM Operation Class" is now part of a challenge profile:

Screenshot 2024-02-19 at 11 04 34 PM

However, there should be 4 profiles that have a defined operation class, yet they are not shown on the profile:

Screenshot 2024-02-19 at 11 07 56 PM

The "Patient Mortality Prediction" challenge (top screenshot) is one of them.

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-app'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-challenge-service'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.1% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-organization-service'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-image-service'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tschaffter
Copy link
Member

Refactored in #2534. Thanks @vpchung for this new feature!

@tschaffter tschaffter closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants