-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): add new operation
property to Challenge schema
#2264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to the other PR, but 0 should not be a valid operation (ID).
apps/openchallenges/challenge-service/src/main/resources/db/migration/V1.0.0__create_tables.sql
Outdated
Show resolved
Hide resolved
libs/openchallenges/api-description/src/components/schemas/ChallengeOperation.yaml
Outdated
Show resolved
Hide resolved
libs/openchallenges/api-description/src/components/schemas/ChallengeOperation.yaml
Outdated
Show resolved
Hide resolved
2024 update:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first comment in the thread should be updated as it includes deprecated information.
Have we discussed how the operation ID is going to be used? I can then implement the necessary changes to the challenge service.
I mentioned on Friday that I plan to add it to the profile for now - I think that will be the easiest win. I can also see it as a search option. |
Remaining TODO (maybe save for another PR?)After updating the Angular CLI client, I was able to use However, there should be 4 profiles that have a defined operation class, yet they are not shown on the profile: The "Patient Mortality Prediction" challenge (top screenshot) is one of them. |
Quality Gate passed for 'openchallenges-app'Issues Measures |
Quality Gate passed for 'openchallenges-challenge-service'Issues Measures |
Quality Gate passed for 'openchallenges-organization-service'Issues Measures |
Quality Gate passed for 'openchallenges-image-service'Issues Measures |
Changelog
operation_id
to Challenge data modeloperation_id
tochallenges
table in DBoperation_id
into the CSV dumpPreview
challenges
tableAPI docs
Challenge profile