-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openchallenges): improve query parameter management using location service #2273
Conversation
…nge at the same time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code refactoring looks great!
I'm having a CORS issue on my end that prevent the challenges from loading in the search page. I will check if this issue is also in main
.
UPDATE: The CORS issue was because a few ports were not properly forwarded by VS Code, including the port of the API gateway and challenge service. Stopping the forwarding of these ports and forwarding them again using VS Code UI solved the issue (see #2279 for more details).
libs/openchallenges/challenge-search/src/lib/challenge-search-filters.ts
Outdated
Show resolved
Hide resolved
@rrchai Filtering orgs by "Contribution Role" does not filter the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
Changelogs
router.navigate
withlocation.replaceState()
to update url params without initiating navigation or scroll restoration*_component.ts
files