feat(schematic): refactor storage endpoints #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewelamb
requested review from
GiaJordan,
linglp,
mialy-defelice and
tschaffter
as code owners
andrewelamb
changed the title
tschaffter
approved these changes
Oct 26, 2023
GiaJordan
approved these changes
Nov 2, 2023
| @@ -131,20 +98,20 @@ paths: | |||
| schema: | |||
| $ref: '#/components/schemas/AssetViewId' | |||
| style: simple | |||
| - description: The ID of a dataset. | |||
| - description: "Type of asset, such as Synapse" | |||
There was a problem hiding this comment.
This is referring to where the data is stored right? Like synapse vs another location? If so, I would change the description to "Type of asset store, such as Synapse" to reflect the language used elsewhere in schematic
There was a problem hiding this comment.
Yep! (the diff is being weird here again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fds-1244