feat(openchallenges): add link to our Discord server to the OC navbar #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This will be for a different PR, but what do you think about integrating a Discord widget into the OC? That way, non-Discord users can still participate and communicate in the channels (as guests) without needing to create a Discord account. |
vpchung
approved these changes
Oct 30, 2023
| styleUrls: ['./discord-button.component.scss'], | ||
| }) | ||
| export class DiscordButtonComponent { | ||
| @Input({ required: false }) label = 'Discord'; |
There was a problem hiding this comment.
Could we use a more descriptive label here? e.g. "Contact us on Discord"
There was a problem hiding this comment.
"Join us on Discord"? (a bit shorter - I will post a preview soon)
|
Arg, I posted the preview but forgot to push the update. I will open another PR to finalize the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2278
Changelog
Preview
Preview design