-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): show role of organizations in Contributors section #2284
Conversation
Thanks for implementing this feature! I'm going to make a 3-min video soon that introduces OC and I thought how cool it would be to have it implemented by then. Here I come again about grouping elements together. 😛 The space between the subtitle and the content should be smaller than the space between the content and the next subtitle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above.
EDIT: What do you think about not displaying empty sections?
EDIT: We prefer to keep the empty sections for a few months to promote challenge organizers to provide the missing information. It has also been discussed that "Not available" should be treated differently than "no sponsor", for instance (valid value) (future work).
Converting to Draft as @vpchung and I are contributing to this PR. |
Here is an example of challenge that includes all three types of contributions (for testing): http://localhost:4200/challenge/8?tab=contributors
|
Component Logic Preview
@vpchung The component logic is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Part 1 for #2222 , focusing on the UIFixes #2222
Changelog
Preview