Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): show role of organizations in Contributors section #2284

Merged
merged 9 commits into from
Nov 3, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Oct 27, 2023

Part 1 for #2222 , focusing on the UI

Fixes #2222

Changelog

  • Add 3 categories to the "Contributors" section of a challenge

Preview

Screenshot 2023-10-27 at 2 28 27 PM

@tschaffter
Copy link
Member

Thanks for implementing this feature! I'm going to make a 3-min video soon that introduces OC and I thought how cool it would be to have it implemented by then.

Here I come again about grouping elements together. 😛

The space between the subtitle and the content should be smaller than the space between the content and the next subtitle.

image

Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

EDIT: What do you think about not displaying empty sections?

EDIT: We prefer to keep the empty sections for a few months to promote challenge organizers to provide the missing information. It has also been discussed that "Not available" should be treated differently than "no sponsor", for instance (valid value) (future work).

@tschaffter tschaffter marked this pull request as draft November 1, 2023 22:56
@tschaffter
Copy link
Member

Converting to Draft as @vpchung and I are contributing to this PR.

@tschaffter
Copy link
Member

tschaffter commented Nov 1, 2023

Here is an example of challenge that includes all three types of contributions (for testing): http://localhost:4200/challenge/8?tab=contributors

Note
The link does not lead directly to the contributions tab (bug).

@tschaffter
Copy link
Member

Component Logic Preview

Note
Organizations are ordered by the number of challenges they have contributed to.

Recording 2023-11-01 at 20 36 32

@vpchung The component logic is ready.

@vpchung
Copy link
Member Author

vpchung commented Nov 2, 2023

UI update:
Screenshot 2023-11-02 at 12 13 45 PM

@vpchung vpchung requested a review from tschaffter November 2, 2023 19:17
@tschaffter tschaffter marked this pull request as ready for review November 2, 2023 19:49
Copy link
Contributor

@rrchai rrchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vpchung vpchung merged commit 6a1c101 into Sage-Bionetworks:main Nov 3, 2023
7 checks passed
@vpchung vpchung deleted the feat-2222 branch November 3, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Show the role of orgs that contribute to a challenge ⭐
3 participants