Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openchallenges): remove Sage from sponsor list #2287

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Oct 30, 2023

Fixes #2285

Preview

Screenshot 2023-10-30 at 11 44 53 AM

@vpchung vpchung self-assigned this Oct 30, 2023
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about setting the style of "OpenChallenge is made possible by" as a title similar to the other sections to increase the importance of this section?

@tschaffter
Copy link
Member

@vpchung Let's make the ITCR clickable to open a new tab with https://itcr.cancer.gov/

@vpchung
Copy link
Member Author

vpchung commented Oct 31, 2023

Let's make the ITCR clickable

I like that! Done.

Screenshot 2023-10-30 at 5 33 26 PM

@vpchung vpchung requested a review from tschaffter October 31, 2023 00:33
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made one suggestion, otherwise it's good to go! Thanks!

@vpchung vpchung merged commit c00cb4c into Sage-Bionetworks:main Oct 31, 2023
6 checks passed
@vpchung vpchung deleted the task-2285 branch October 31, 2023 18:21
mdsage1 pushed a commit to mdsage1/sage-monorepo that referenced this pull request Nov 1, 2023
…2287)

* remove Sage from sponsor list

* apply section-title styling

* link out to ITCR website

* use more descriptive variable name
tschaffter added a commit that referenced this pull request Nov 3, 2023
* added unit tests for api, model and exception

* update the unit tests

* fix typos in files for unit test

* move folder to correct top folder

* comment out failing test

* remove files

* update istest

* Update label of the Discord button (#2288)

* fix(openchallenges): upgrade legacy components (#2290)

* not-found page: upgrade MatCard

* org-profile page: remove unused tabs component

* github-button: upgrade MatButton

* _app-theme: upgrade legacy; fix fonts

* navbar: upgrade MatButton; fix colors and padding

* fix typography for buttons

* signup page: upgrade components

* add required `mat-label`

* update styles to account for changes

* user-button: upgrade MatButton, MatMenu

* update styles to account for changes

* upgrade component in commented code

* remove dependency on legacy-* in _app-theme

* add typography to discord button; add discord theme

* schematic: remove unused font; upgrade legacies

* fix(openchallenges): remove Sage from sponsor list (#2287)

* remove Sage from sponsor list

* apply section-title styling

* link out to ITCR website

* use more descriptive variable name

* chore(schematic): remove `schematic-app` and `schematic-api-client-angular` (#2293)

* Remove schematic-app and schematic-api-client-angular

* Update `tsconfig.base.json`

* feat(sage-monorepo): enable Format on Save for JSON and JSON with Comments (#2294)

* Format JSON on save

* Enable format on save for jsonc

* hide page size options on search pages (#2298)

* delete

* img hgt exception test

* final image height exception test

* update

* additional variable formatting

* updtate unittest

---------

Co-authored-by: Thomas Schaffter <[email protected]>
Co-authored-by: Verena Chung <[email protected]>
Co-authored-by: Rongrong Chai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update OpenChallenges is made possible by...
2 participants