feat(sage-monorepo): enable Format on Save for JSON and JSON with Comments #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdsage1
pushed a commit
to mdsage1/sage-monorepo
that referenced
this pull request
Nov 1, 2023
…ments (Sage-Bionetworks#2294) * Format JSON on save * Enable format on save for jsonc
tschaffter
added a commit
that referenced
this pull request
Nov 3, 2023
* added unit tests for api, model and exception * update the unit tests * fix typos in files for unit test * move folder to correct top folder * comment out failing test * remove files * update istest * Update label of the Discord button (#2288) * fix(openchallenges): upgrade legacy components (#2290) * not-found page: upgrade MatCard * org-profile page: remove unused tabs component * github-button: upgrade MatButton * _app-theme: upgrade legacy; fix fonts * navbar: upgrade MatButton; fix colors and padding * fix typography for buttons * signup page: upgrade components * add required `mat-label` * update styles to account for changes * user-button: upgrade MatButton, MatMenu * update styles to account for changes * upgrade component in commented code * remove dependency on legacy-* in _app-theme * add typography to discord button; add discord theme * schematic: remove unused font; upgrade legacies * fix(openchallenges): remove Sage from sponsor list (#2287) * remove Sage from sponsor list * apply section-title styling * link out to ITCR website * use more descriptive variable name * chore(schematic): remove `schematic-app` and `schematic-api-client-angular` (#2293) * Remove schematic-app and schematic-api-client-angular * Update `tsconfig.base.json` * feat(sage-monorepo): enable Format on Save for JSON and JSON with Comments (#2294) * Format JSON on save * Enable format on save for jsonc * hide page size options on search pages (#2298) * delete * img hgt exception test * final image height exception test * update * additional variable formatting * updtate unittest --------- Co-authored-by: Thomas Schaffter <[email protected]> Co-authored-by: Verena Chung <[email protected]> Co-authored-by: Rongrong Chai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2292
Changelog