Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openchallenges): refactor tab switching to preserve scroll position on profile pages #2316

Merged
merged 14 commits into from
Nov 4, 2023
Merged

fix(openchallenges): refactor tab switching to preserve scroll position on profile pages #2316

merged 14 commits into from
Nov 4, 2023

Conversation

rrchai
Copy link
Contributor

@rrchai rrchai commented Nov 3, 2023 •
edited
Loading

Changelog

  • Update tab switching on profile pages to avoid navigations, which will fix

    1. the scrolling position jumps back to top after switching tabs
    2. the challenge slug disappeared from the URL after switching tabs

    reset-scroll

  • Ensure URL parameters sync with active tab

    i.e. Typing /org/dream?tab=members will go to 'member' section

    org-member

@rrchai rrchai self-assigned this Nov 3, 2023
@rrchai rrchai marked this pull request as ready for review November 3, 2023 23:54
tschaffter
tschaffter approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one small comment

libs/openchallenges/org-profile/src/lib/org-profile.component.ts Outdated Show resolved Hide resolved
@rrchai rrchai merged commit f2ad264 into Sage-Bionetworks:main Nov 4, 2023
7 checks passed
@rrchai rrchai deleted the fix-scroll-on-profiles branch November 4, 2023 00:34
@tschaffter tschaffter mentioned this pull request Nov 4, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

@vpchung vpchung Awaiting requested review from vpchung

Assignees

@rrchai rrchai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Challenge & org pages jump to the top when selecting a section ⭐
2 participants
@rrchai @tschaffter