Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openchallenges): fix challenge descriptions #2371

Merged
merged 4 commits into from
Nov 18, 2023
Merged

fix(openchallenges): fix challenge descriptions #2371

merged 4 commits into from
Nov 18, 2023

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Nov 17, 2023 •
edited
Loading

Changelog

  • fix acronym casing in challenge descriptions, e.g. miccai/Miccai → MICCAI, covid-19 → COVID-19, etc.
  • convert descriptions in proper case to sentence case
  • typo fixes

@vpchung
Copy link
Member Author

vpchung commented Nov 17, 2023

Ah, looks like some of the descriptions are proper casing.

Will need to fix that too~

@vpchung vpchung marked this pull request as draft November 17, 2023 23:17
@vpchung vpchung changed the title fix(openchallenges): fix acronym casing in challenge descriptions fix(openchallenges): fix challenge descriptions Nov 17, 2023
@vpchung vpchung self-assigned this Nov 17, 2023
@vpchung vpchung marked this pull request as ready for review November 17, 2023 23:37
gaiaandreoletti
gaiaandreoletti reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@gaiaandreoletti gaiaandreoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @vpchung !

gaiaandreoletti
gaiaandreoletti reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@gaiaandreoletti gaiaandreoletti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great

tschaffter
tschaffter approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@tschaffter tschaffter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of Gaia (Slack)

@tschaffter
Copy link
Member

tschaffter commented Nov 18, 2023 •
edited
Loading

@vpchung Following a discussion with Gaia this week, we should move away from cropped headlines (generated from the description?), and prefer empty headlines until we get one that meet the specification.

@tschaffter tschaffter self-requested a review November 18, 2023 01:27
@tschaffter
Copy link
Member

See last commit and comment. Merging now.

@tschaffter tschaffter merged commit 2e66bb3 into Sage-Bionetworks:main Nov 18, 2023
6 checks passed
@vpchung vpchung deleted the db-fix_challenge-desc branch November 18, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaiaandreoletti gaiaandreoletti gaiaandreoletti left review comments

@tschaffter tschaffter Awaiting requested review from tschaffter tschaffter is a code owner

Assignees

@vpchung vpchung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpchung @tschaffter @gaiaandreoletti