-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schematic): integration testing #2400
Conversation
* changed authenticication so that only endpoints that need it have it * updated schematic * add patch for access token * schema endpoints no longer mockeed * added tests for handle exceptions * added integration tests * marked synapse tests * added error handling for bad schema urls * fix error message * add workflow for end to end testing * fix some test results * add unit mark * add unit mark * add workflow for testing with secrets * rename file * fix synapse test file when secrets file doesnt exists * fix test workflows * turned synapse ids into secrets in workflow * turned synapse ids into secrets in workflow
@tschaffter @GiaJordan Can I get your approval on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving per discussion on slack with @andrewelamb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can you please add a high-level description of what this PR is doing? When is this workflow being triggered?
- Why does the title of the PR includes "(feat(schematic): integration testing #2398)"?
- The new GH workflow duplicates parts of the CI workflow common to all projects. This would lead to a waste of resources. Based on previous discussions, you may want this PR to focus on integration testing for Schematic. Also, now or in another PR, you could consider running it AFTER the common CI workflow successfully passes, so that e2e testing is not run if the linting check fails, for instance.
Can I get rid of the "The new GH workflow duplicates parts of the CI workflow common to all projects. This would lead to a waste of resources." What parts cna I get rid of in the |
This is identical to #2398 plus some fixes to the testing workflow.
This PR chas a new wrokflow that is trggred when PRs are made from the new
Schematic-API-Staging
branch intomain
.This PR: