-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): add EDAM concept table to the chalenge service #2521
feat(openchallenges): add EDAM concept table to the chalenge service #2521
Conversation
Co-authored-by: Verena Chung <[email protected]>
Co-authored-by: Verena Chung <[email protected]>
Quality Gate passed for 'openchallenges-challenge-service'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor request, unless it's no longer relevant.
apps/openchallenges/challenge-service/src/main/resources/db/edam_concept.csv
Show resolved
Hide resolved
apps/openchallenges/challenge-service/src/main/resources/application.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my end - thanks!
Closes #2520
Description
Add a minimal version of EDAM ontology as a new SQL table in the challenge service DB.
This contribution is a refactored version of #2265 that aims to integrate EDAM into OC one step at a time.
In the near future, I can see us using the following workflow, which the present PR brings us close to.
Why? The entire EDAM ontology is more than 2MB and too large to be tracked in Sage Monorepo. Using an ETL workflow would allow us to store the raw data externally (e.g. S3 bucket, Synapse).
I actually have implemented this workflow for iAtlas a few weeks ago (see
apps/iatlas/data
). This workflow could be reused almost as is with OC. Note that the projectiatlas-data
uses Schematic to validate the iAtlas data, which is a feature that @vpchung suggested recently for OC.Changelog
OC_EDAM_1.25
to OC shared folder in Google DriveTesting
Future Work
Add the property
Challenge.operation
Preview