Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): add EDAM concept table to the chalenge service #2521

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Feb 22, 2024

Closes #2520

Description

Add a minimal version of EDAM ontology as a new SQL table in the challenge service DB.

This contribution is a refactored version of #2265 that aims to integrate EDAM into OC one step at a time.

In the near future, I can see us using the following workflow, which the present PR brings us close to.

  1. We fork the repo https://github.com/edamontology/edamontology to prevent data from being deleted
  2. We have an ETL workflow that
    • E: download the CSV file from the EDAM fork
    • T: a python script that converts the CSV file into a format that OC can work with; optionally validate the input and output data.
    • L: load the processed data into OC DB

Why? The entire EDAM ontology is more than 2MB and too large to be tracked in Sage Monorepo. Using an ETL workflow would allow us to store the raw data externally (e.g. S3 bucket, Synapse).

I actually have implemented this workflow for iAtlas a few weeks ago (see apps/iatlas/data). This workflow could be reused almost as is with OC. Note that the project iatlas-data uses Schematic to validate the iAtlas data, which is a feature that @vpchung suggested recently for OC.

Changelog

  • add minimal EDAM ontology to OC Challenge Service
  • document in the ticket how the processed EDAM CSV file is generated with minimal manual operations
  • add the Google sheet OC_EDAM_1.25 to OC shared folder in Google Drive

Testing

  • The new SQL table is created and populated when starting the challenge service
    • using Docker
    • using the development server

Future Work

Add the property Challenge.operation

Preview

image

@tschaffter tschaffter self-assigned this Feb 22, 2024
@tschaffter tschaffter added the sonar-scan-approved-deprecated Ready for Sonar code analysis label Feb 22, 2024
@tschaffter tschaffter marked this pull request as ready for review February 22, 2024 01:19
Copy link

Quality Gate Passed Quality Gate passed for 'openchallenges-challenge-service'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tschaffter tschaffter changed the title feat(openchallenges): add EDAM ontology to the OC Challenge Service feat(openchallenges): add EDAM ontology table to the OC Challenge Service Feb 22, 2024
@tschaffter tschaffter changed the title feat(openchallenges): add EDAM ontology table to the OC Challenge Service feat(openchallenges): add EDAM SQL table to the OC Challenge Service Feb 22, 2024
@tschaffter tschaffter changed the title feat(openchallenges): add EDAM SQL table to the OC Challenge Service feat(openchallenges): add EDAM concept table to the OC Challenge Service Feb 22, 2024
@tschaffter tschaffter changed the title feat(openchallenges): add EDAM concept table to the OC Challenge Service feat(openchallenges): add EDAM concept table to the chalenge service Feb 22, 2024
Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request, unless it's no longer relevant.

Copy link
Member

@vpchung vpchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end - thanks!

@tschaffter tschaffter merged commit a81c5be into Sage-Bionetworks:main Feb 23, 2024
24 checks passed
@tschaffter tschaffter deleted the add-edam-ontology branch February 23, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Add EDAM ontology to the OC Challenge Service
2 participants