-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(agora): TEST PR #2891
Closed
sagely1
wants to merge
1,315
commits into
Sage-Bionetworks:sage-monorepo/drawio-roles-in-software-development
from
sagely1:agora/migration-gene-search
Closed
feat(agora): TEST PR #2891
sagely1
wants to merge
1,315
commits into
Sage-Bionetworks:sage-monorepo/drawio-roles-in-software-development
from
sagely1:agora/migration-gene-search
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: vpchung <[email protected]>
Using my admin super powers to quickly create a commit on `main` to test Sage-Bionetworks#2538
Co-authored-by: vpchung <[email protected]>
Co-authored-by: vpchung <[email protected]>
…age-Bionetworks#2534) Co-authored-by: Verena Chung <[email protected]>
Co-authored-by: vpchung <[email protected]>
Co-authored-by: vpchung <[email protected]>
Co-authored-by: vpchung <[email protected]>
…eration ID and preferred label (Sage-Bionetworks#2555)
Co-authored-by: vpchung <[email protected]>
…age-Bionetworks#2557) Co-authored-by: Verena Chung <[email protected]>
Co-authored-by: vpchung <[email protected]>
…coverage (Sage-Bionetworks#2507) Co-authored-by: Thomas Schaffter <[email protected]>
sagely1
changed the title
checking in progress of gene-search component
feat(agora): checking in progress of gene-search component (AG-1585)
Nov 25, 2024
sagely1
commented
Nov 25, 2024
sagely1
commented
Nov 25, 2024
libs/agora/api-client-angular/src/lib/model/overallScoresDistribution.ts
Outdated
Show resolved
Hide resolved
sagely1
commented
Nov 25, 2024
libs/agora/api-description/src/components/schemas/OverallScoresDistribution.yaml
Outdated
Show resolved
Hide resolved
sagely1
commented
Nov 25, 2024
sagely1
commented
Nov 25, 2024
sagely1
commented
Nov 25, 2024
libs/agora/ui/src/lib/components/modal-link/modal-link.component.ts
Outdated
Show resolved
Hide resolved
sagely1
commented
Nov 25, 2024
sagely1
commented
Nov 25, 2024
tschaffter
approved these changes
Nov 25, 2024
libs/agora/genes/src/lib/components/gene-search/assets/close-icon/close-icon.component.ts
Outdated
Show resolved
Hide resolved
sagely1
changed the base branch from
main
to
sage-monorepo/drawio-roles-in-software-development
November 26, 2024 00:20
sagely1
changed the title
feat(agora): checking in progress of gene-search component (AG-1585)
feat(agora): TEST PR
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial migration of Agora gene-search component
Also migrates the nomination form
miscellaneous fixes (missing properties in objects in OpenAPI, adding fullscreen functionality, folder structure changes, svg icon component changes)
Changelog
Added packages for services:
Acceptance criteria
Ensure that gene-search is available in the header when on the home page and also when navigating to different pages