-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sage): create the project sage-otel-collector (ARCH-324) #2908
feat(sage): create the project sage-otel-collector (ARCH-324) #2908
Conversation
- '8888:8888' # Prometheus metrics exposed by the collector | ||
- '8889:8889' # Prometheus exporter metrics | ||
- '13133:13133' # health_check extension | ||
- '4317:4317' # OTLP gRPC receiver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my purpose only 13133 and 4318 are needed. I am sending data over http instead of grpc
If you are planning to use this for OC, then some more ports are needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is addressed in #2909.
Closes https://sagebionetworks.jira.com/browse/ARCH-324
Changelog
project.json
with task to build, scan and serve the app.docker/sage
.Preview
Build the Docker image
nx build-image sage-otel-collector
Output:
Note
The task
build-image
for this project is automatically inferred by the Sage Monorepo Nx Plugin, eliminating the need to define it inproject.json
.Scan the Docker image with Trivy
Start the Docker container locally
nx serve-detach sage-otel-collector
Output:
Publish the Docker image to GHCR
This Docker image
ghcr.io/sage-bionetworks/sage-otel-collector
will be published to GHCR with the tag "edge" and "sha-<7-digit commit ID>" when merging this PR to themain
branch. This behavior is defined by the taskpublish-image
(will be automatically inferred in the future like the taskbuild-image
) and the main CI/CD workflow.Publishing this image with a semver version will be described in a following PR.