-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dev container #1060
base: develop
Are you sure you want to change the base?
feat: Add dev container #1060
Conversation
This PR does not change the code of schematic so I'm not sure why the tests are failing. |
@tschaffter I think tests fail because the request is from a different fork. I wouldn't worry about that, unless you'd like to :) |
Just to confirm, @tschaffter the goal of this request - in addition to the various other features of the dev container - is to speed up CI/CD actions? |
@GiaJordan could you review this PR? I think we can evaluate it and merge it next year (i.e. not urgent for the holidays :) |
@milen-sage Yes, among other benefits to your team. |
Following a discussion with Milen, I should have the chance to present to the FAIR Data team the benefits of developing inside a dev container early next year. |
This could be a good retrospective topic to implement this as a practice when developing |
Fixes #1059
Changelog
tools/
with the script required to build the dev container image sagebionetworks/schematic-devcontainer.workspace-*
commands indev-env.sh
.workspace-install
to install the project dependencies.Preview
Develop inside the dev container with VS Code
Ctrl+Shift+P
)python --version
andpoetry --version
Develop inside a GitHub Codespace
GitHub Codespace is a new feature that was released in November 2022. It relies on the dev container standard to spin up a development environment for projects that include a dev container definition. You can try starting a GH Codespace using the branch behind this PR.
Future Work