-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FDS-2525] Authenticated export of telemetry data #1527
Conversation
…s-2386-synapse-refactoring
…enticated export of telemetry data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! Thanks for doing this. Make sense to me, I'll leave it to at least one other developer to review this.
@BryanFauble The changes look good to me! |
Quality Gate passedIssues Measures |
* Authenticated export of telemetry data, updating to HTTP otel library
Problem:
Solution:
requests-oauth2client
library that will handle the oauth2 token exchange with Auth0 for us if the environment variables are set.requests.Session()
object that the opentelemetry exporter uses to send data out.Testing:
https://dev.sagedpe.org
URL tooTODO:
verify=False
for the HTTP POST logic when non-self signed certs can be used.