chore: upgrade to node version 20 (FE-6252) #6424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsium
force-pushed
the
FE-6252-node-20
branch
2 times, most recently
from
4cbd51b
to
2b726e8
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ecbe103:
|
Parsium
added
In Progress
and removed
Pending Review
No QA Required
No UX QA Required
labels
Parsium
force-pushed
the
FE-6252-node-20
branch
11 times, most recently
from
89b2f58
to
c856ee3
Compare
Parsium
added
Pending Review
Pending QA
No UX QA Required
and removed
In Progress
labels
Parsium
force-pushed
the
FE-6252-node-20
branch
from
c856ee3
to
edc65ef
Compare
Parsium
commented
Nov 23, 2023
| @@ -4,5 +4,5 @@ | |||
| "carbon-quickstart-typescript-6sjfuz" | |||
| ], | |||
| "buildCommand": "precompile", | |||
| "node": "16" | |||
| "node": "18" | |||
There was a problem hiding this comment.
note: the Codesandbox CI bot currently doesn't support Node 20, Node 18 is the latest version it supports
There was a problem hiding this comment.
Yeah they're usually a bit behind on updating (understandably)
Parsium
force-pushed
the
FE-6252-node-20
branch
from
edc65ef
to
6d14434
Compare
Parsium
force-pushed
the
FE-6252-node-20
branch
7 times, most recently
from
6141b7e
to
8339132
Compare
Parsium
commented
Dec 7, 2023
| @@ -1,4 +1,4 @@ | |||
| import { Page } from "playwright-core"; | |||
| import { Page } from "@playwright/test"; | |||
There was a problem hiding this comment.
note: for future Playwright migrations, we should import any needed TypeScript types from this package as opposed to playwright-core, since playwright-core is an internal package and the Playwright team could change this at any time.
DipperTheDan
previously approved these changes
Dec 7, 2023
divyajindel
previously approved these changes
Dec 7, 2023
Temporarily restrict the following packages to assist with updating: - @playwright/experimental-ct-react17 - @axe-core/playwright - @types/styled-components - @sage/design-tokens (dev dependency only) - @floating-ui/dom - @floating-ui/react-dom - @tanstack/react-virtual - cypress Install @playwright/test at same version as @playwright/experimental-ct-react17, to address issue with imported TypeScript types not being found.
Override version of playwright-core, so @axe-core/playwright and @playwright-experiment-ct-react17 reference the same package. Without this, npm would install two different versions of playwright-core, which would cause TypeScript types between the two versions to clash.
Parsium
dismissed stale reviews from divyajindel and DipperTheDan
via
ecbe103
Parsium
force-pushed
the
FE-6252-node-20
branch
from
8339132
to
ecbe103
Compare
edleeks87
approved these changes
Dec 7, 2023
|
🎉 This PR is included in version 124.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
package-lock.jsonto use the latest file format (more details in the npm docs)Current behaviour
Checklist
d.tsfile added or updated if requiredQA
Additional context
To assist with regenerating the package lock file, several packages have been locked to specific versions/ restricted to specific version ranges. These packages and their locked versions are below:
@playwright/experimental-core-react17to~1.36.2@playwright/testto~1.36.2@axe-core/playwrightto~4.7.3@sage/design-tokens(dev dependency only) to~4.17.0@floating-ui/domto~1.2.9@floating-ui/react-domto~1.3.0cypressto~12.13.0@types/styled-componentsto5.1.171@tanstack/react-virtualto3.0.0-beta.54These will eventually need updating to later versions.
Testing instructions
Pre-setup
nvm install lts/ironnpm ciTests
npmscriptsFootnotes
Should be
4.4.xto match[email protected], but type errors were encountered on the latest4.4.xversion. ↩