Select list width #6991
Merged
Select list width #6991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edleeks87
force-pushed
the
select-list-width
branch
5 times, most recently
from
5b06e71
to
e609527
Compare
10 tasks
DipperTheDan
previously approved these changes
Oct 2, 2024
Parsium
reviewed
Oct 7, 2024
Parsium
previously approved these changes
Oct 7, 2024
edleeks87
force-pushed
the
select-list-width
branch
from
e609527
to
c259fb2
Compare
Parsium
previously approved these changes
Oct 9, 2024
edleeks87
force-pushed
the
select-list-width
branch
from
c259fb2
to
f3c1d79
Compare
Parsium
previously approved these changes
Oct 9, 2024
DipperTheDan
previously approved these changes
Oct 9, 2024
…input Removes `left` and `right` options from `listPlacement` type, only `top` and `bottom` remain supported BREAKING CHANGE: `listPlacement` prop only supports `top` and `bottom` now
…ding the list width Adds support for overriding the list width via `listWidth` prop. Adds support for placing list at `top-start`, `top-end`, `bottom-start` and `botton-end`. When `top` or `bottom` is passed to `listPlacement` it will internally append `-end` to it. fix #6861
edleeks87
force-pushed
the
select-list-width
branch
from
f3c1d79
to
c3853cd
Compare
DipperTheDan
approved these changes
Oct 10, 2024
Parsium
approved these changes
Oct 10, 2024
dariusbercea-sage
approved these changes
Oct 10, 2024
|
🎉 This PR is included in version 143.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6861
Proposed behaviour
Removes
leftandrightoptions fromlistPlacementtype, onlytopandbottomremain supportedBREAKING CHANGE:
listPlacementprop only supportstopandbottomnowAdds support for overriding the list width via
listWidthprop. Adds support for placinglist at
top-start,top-end,bottom-startandbotton-end. Whentoporbottomis passed to
listPlacementit will internally append-endto it.Current behaviour
listPlacementsupportsleftandrightno support for
listWidthChecklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions