fix(select): prevent deprecation warning about uncontrolled textbox from being fired #6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom being fired Ensures that Textbox used in Select components is used in a controlled manner to prevent the deprecation warnings from being fired fix #6883
edleeks87
force-pushed
the
FE-6759-select-uncontrolled
branch
from
2028223
to
6de179c
Compare
nuria1110
approved these changes
Oct 3, 2024
Parsium
approved these changes
Oct 4, 2024
dariusbercea-sage
approved these changes
Oct 7, 2024
|
🎉 This PR is included in version 142.13.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6883
Proposed behaviour
Ensures that Textbox used in Select components is used in a controlled manner to prevent the deprecation warnings from being fired. Removes onChange from SelectTextbox interface as we never pass it (handled in the parent Select components). Passes empty function to Textbox to prevent the warning.
Current behaviour
Deprecation warning is fired about uncontrolled textbox when Selects are used
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions