fix(action-popover): ensure that opening using the up arrow focuses last focusable element - FE-6793 #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edleeks87
reviewed
Oct 9, 2024
src/components/action-popover/__internal__/action-popover-utils.tsx
Outdated
Show resolved
Hide resolved
src/components/action-popover/action-popover-menu/action-popover-menu.component.tsx
Show resolved
Hide resolved
src/components/action-popover/__internal__/action-popover-utils.tsx
Outdated
Show resolved
Hide resolved
DipperTheDan
force-pushed
the
FE-6793_action-popover-keyboard-focus-last-element
branch
3 times, most recently
from
0544ec0
to
d9866a7
Compare
edleeks87
reviewed
Oct 15, 2024
edleeks87
reviewed
Oct 15, 2024
edleeks87
approved these changes
Oct 16, 2024
mihai-albu-sage
approved these changes
Oct 16, 2024
dariusbercea-sage
approved these changes
Oct 18, 2024
…ast element in the menu Currently we have a bug whereby when a user presses the up arrow key, the first focusable item in the menu is focused. This appears to be a bug as we have code that specifically handles this behaviour but is overridden elsewhere in the code. This fix ensures that the last focusable item is focused. fixes #6826
DipperTheDan
force-pushed
the
FE-6793_action-popover-keyboard-focus-last-element
branch
from
2a02cba
to
38aaed9
Compare
DipperTheDan
deleted the
FE-6793_action-popover-keyboard-focus-last-element
branch
|
🎉 This PR is included in version 143.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have a bug whereby when a user presses the up arrow key, the first focusable item in the menu is focused. This appears to be a bug as we have code that specifically handles this behaviour but is overridden elsewhere in the code. This fix ensures that the last focusable item is focused.
fixes #6826
Proposed behaviour
Up Arrowkey should open the menu and focus the last focusable element.Screen.Recording.2024-10-08.at.09.40.36.mov
Current behaviour
Up Arrowkey opens the menu and focuses the first focusable element.Screen.Recording.2024-10-08.at.09.42.22.mov
Checklist
d.tsfile added or updated if requiredQA
Additional context
N/A
Testing instructions
Up Arrowkey focuses on the last focusable element in the menu.