Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(date-range): remove flaky blur test - FE-6850 #7006

Merged
merged 1 commit into from
Oct 9, 2024
Merged

test(date-range): remove flaky blur test - FE-6850 #7006

merged 1 commit into from
Oct 9, 2024

Conversation

DipperTheDan
Copy link
Contributor

Proposed behaviour

Remove flaky blur test

Current behaviour

Blur test is one the tests responsible for Playwright tests flaking

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

No specific testing required but this will need QA approval due to amendment of a PW file.

@DipperTheDan DipperTheDan self-assigned this Oct 9, 2024
@Parsium Parsium marked this pull request as ready for review October 9, 2024 15:27
@Parsium Parsium requested a review from a team as a code owner October 9, 2024 15:27
@DipperTheDan DipperTheDan merged commit dfba661 into master Oct 9, 2024
25 checks passed
@DipperTheDan DipperTheDan deleted the remove-flaky-date-range-test branch October 9, 2024 15:34
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 143.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Parsium Parsium Parsium approved these changes

@stephenogorman stephenogorman stephenogorman approved these changes

@tomdavies73 tomdavies73 tomdavies73 approved these changes

Assignees

@DipperTheDan DipperTheDan

Labels
No UX QA Required Passed QA Passed Review released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DipperTheDan @carbonci @Parsium @stephenogorman @tomdavies73