Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(box): remove focus outline #7011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(box): remove focus outline #7011

wants to merge 1 commit into from

Conversation

tomdavies73
Copy link
Contributor

Proposed behaviour

Removes all outlines when the component is focused, removes default browser outline when the component is focused with a set tabIndex.

Current behaviour

Currently, browsers apply a default outline when the component is focused with a set tabIndex.

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Copy link
Contributor Author

@tomdavies73 tomdavies73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is worth noting this PR removes the default focus styling added by browsers for consuming teams using tabIndex on the Box component.

However, due to Box being a layout based component, there are potential plans to deprecate and remove tabIndex from Box to prevent misuse of the component in the future.

@tomdavies73 tomdavies73 marked this pull request as ready for review October 11, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants