fix(badge): ensure badge does not appear under child components #7012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuria1110
changed the title
tomdavies73
previously approved these changes
Oct 10, 2024
DipperTheDan
previously approved these changes
Oct 11, 2024
nuria1110
dismissed stale reviews from DipperTheDan and tomdavies73
via
b5798bf
tomdavies73
previously approved these changes
Oct 15, 2024
DipperTheDan
previously approved these changes
Oct 15, 2024
This fix ensures badge does not appear under child components. fix #6765
nuria1110
dismissed stale reviews from DipperTheDan and tomdavies73
via
d88d3ec
nuria1110
commented
Oct 15, 2024
| @@ -44,6 +44,7 @@ const StyledBadge = styled.span.attrs(({ onClick }) => ({ | |||
| width: 22px; | |||
| min-height: 22px; | |||
| border: solid 2px transparent; | |||
| z-index: 2; | |||
There was a problem hiding this comment.
Added this to fix issue found during QA:
DipperTheDan
approved these changes
Oct 16, 2024
dariusbercea-sage
approved these changes
Oct 16, 2024
tomdavies73
approved these changes
Oct 16, 2024
|
🎉 This PR is included in version 143.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6765
Proposed behaviour
Badge appears over child components.
Current behaviour
Badge appears underneath child components.
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions