Option comps rtl #7014
Merged
Option comps rtl #7014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsium
reviewed
Oct 11, 2024
Comment on lines
6
to
8
| const mockedGuid = "guid-12345"; | ||
| jest.mock("../../../__internal__/utils/helpers/guid"); | ||
| (guid as jest.MockedFunction<typeof guid>).mockImplementation(() => mockedGuid); |
There was a problem hiding this comment.
question: it doesn't appear we are asserting the id set on an underlying element in any of the tests. Is this mock required for something else?
There was a problem hiding this comment.
This one can be removed, I'm actually going to keep it in the other ones as we should be testing when the user set a custom id or not etc
| expect(option).not.toHaveAttribute("aria-disabled"); | ||
| }); | ||
|
|
||
| it("should call `onSelect` or `onClick` when the user clicks on the element", async () => { |
There was a problem hiding this comment.
suggestion(non-blocking): what do you think of this so it reflects calling both event handlers?
Suggested change
| it("should call `onSelect` or `onClick` when the user clicks on the element", async () => { | |
| it("should call `onSelect` and `onClick` when the user clicks on the element", async () => { |
edleeks87
force-pushed
the
option-comps-rtl
branch
from
592a521
to
ef7e9d2
Compare
Parsium
reviewed
Oct 11, 2024
edleeks87
force-pushed
the
option-comps-rtl
branch
2 times, most recently
from
fed4db4
to
c5e43d8
Compare
tomdavies73
previously approved these changes
Oct 11, 2024
Parsium
reviewed
Oct 11, 2024
| expect(screen.queryByRole("option", { name: "bar" })).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| test("should set guid as `id` on the elment when none passed", () => { |
There was a problem hiding this comment.
typo:
Suggested change
| test("should set guid as `id` on the elment when none passed", () => { | |
| test("should set guid as `id` on the element when none passed", () => { |
| expect(onClick).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it("should call `onSelect` when the user clicks on the element and `onClick` is not set but custom `id` passed", async () => { |
There was a problem hiding this comment.
suggestion(non-blocking): what do you think of this wording tweak for clarity?
Suggested change
| it("should call `onSelect` when the user clicks on the element and `onClick` is not set but custom `id` passed", async () => { | |
| it("calls `onSelect` when clicked and neither `onClick` nor `id` are set", async () => { |
| }); | ||
| }); | ||
|
|
||
| it("should call `onSelect` when the user clicks on the element and `onClick` is not set but custom `id` is passed", async () => { |
There was a problem hiding this comment.
suggestion(non-blocking): similarly, what do you think about this tweak for clarity?:
Suggested change
| it("should call `onSelect` when the user clicks on the element and `onClick` is not set but custom `id` is passed", async () => { | |
| it("calls `onSelect` when clicked, without `onClick` set, but with `id` provided.", async () => { |
edleeks87
force-pushed
the
option-comps-rtl
branch
from
c5e43d8
to
77fcc4e
Compare
tomdavies73
approved these changes
Oct 11, 2024
Parsium
approved these changes
Oct 11, 2024
paulrobinson88
approved these changes
Oct 11, 2024
|
🎉 This PR is included in version 143.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Converts Option, OptionGroupHeader and OptionRow unit tests to RTL
Current behaviour
Option, OptionGroupHeader and OptionRow unit tests are enzyme
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions