Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu fixes #7017

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Menu fixes #7017

wants to merge 3 commits into from
+300 −222

Commits on Oct 18, 2024

  1. fix(menu, menu-item): ensure that menu-items all remain the same heig… 

    …ht if any wrap to new lines

Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new
lines at smaller screen resolutions. Ensures no additional padding is set on `MenuItem` children of
`MenuFullscreen`.

BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`,
`overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`,
`maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and
`display` props.

fix #6934, fix #7000
    @edleeks87
    edleeks87 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0c3caa4 View commit details
    Browse the repository at this point in the history

  2. fix(menu-item): ensure that it does not render children when `submenu… 

    …` is an empty string

Adds invariant to ensure that the component does not render when `children` are passed but `submenu`
is an empty string

fix #7010
    @edleeks87
    edleeks87 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    4c220a0 View commit details
    Browse the repository at this point in the history

  3. chore: some small tweaks by ed leeks tbs

    @edleeks87
    edleeks87 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    f262259 View commit details
    Browse the repository at this point in the history