Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Provide combined CSS output file for distribution #375

Merged
merged 27 commits into from
Sep 20, 2024

Conversation

adrianbruntonsagecom
Copy link
Contributor

@adrianbruntonsagecom adrianbruntonsagecom commented Sep 16, 2024

Extends the build process to provide a CSS file for use directly by consumers. Changes made:

  • Reverts inclusion of media queries and specific CSS classes by build process to ensure it is as generic as possible
  • An all.css file is made available for each brand token type (frozenproduct, marketing & product) which contains the following features:
    • Media query for large screen tokens configurable by a new --global-size-breakpoint-min-width token
    • Consolidation to remove any tokens across screen sizes which are present with the same value in other descending screen sizes
    • Formatter to rename light/dark mode token to add a suffix and include the light-dark function where ever used. This will allow consumers to switch to light/dark mode (or device specified) on a page or section level using the color-scheme css property: https://web.dev/articles/light-dark

A single CSS file has been used because for most of the token levels as the tokens are often dependant on each other. EG, it doesn't make sense to include the light tokens only without also including dark tokens when the components now require both for the light-dark function. Similarly with the screen size tokens - one screen size is insufficient given the use of media queries.

This makes both responsiveness and light/dark mode a built in an expected feature of the tokens for consumers to use.

An example index.html file has been provided in each distributed brand token directory to aid consumption of these tokens and show how they can be implemented with light/dark modes.

@adrianbruntonsagecom adrianbruntonsagecom changed the base branch from master to beta September 16, 2024 16:00
@druhill druhill merged commit fcb3e2f into Sage:beta Sep 20, 2024
3 checks passed
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 5.0.0-beta.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants