Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the signup form submission #20

Merged

Conversation

RahulK4102
Copy link
Contributor

@RahulK4102 RahulK4102 commented May 13, 2024

Describe

the data which we were collecting from the user on sign up page was not getting stored in database

Issue

resolves #9

the data which we were collecting from the user on sign up page was not getting stored in database
Copy link
Collaborator

@aswinikalyan30 aswinikalyan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if you revert the changes for the SQL file

--

INSERT INTO `login` (`school_id`, `firstname`, `lastname`, `email`, `password`, `class_id`, `avatar`, `date_created`) VALUES
(2147483647, 'First Name', 'Last Name', 'Email', '$2y$10$V92q2fOjeVF2w3nytZW.0ujYaXRIkgGjvgxM4YeORjH.DYoeghPgG', 0, 0x6e6f2d696d6167652d617661696c61626c652e706e67, '2024-05-11 18:07:06'),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this SQL exported from the local db setup?
I suggest you can remove the repetitive records here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the SQL which was exported from my local db setup

Copy link
Collaborator

@aswinikalyan30 aswinikalyan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aswinikalyan30 aswinikalyan30 merged commit 597e915 into SaiyamTuteja:main May 14, 2024
1 check passed
@aswinikalyan30 aswinikalyan30 added gssoc Contribution to GSSoC '24 level2 Enhancements/ bugs of medium complexity labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Contribution to GSSoC '24 level2 Enhancements/ bugs of medium complexity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] : sign up
2 participants