Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#32: Change TEXT to VARCHAR for avatar columns to allow default va… #38

Merged
merged 2 commits into from
May 20, 2024

Conversation

Swapnilden
Copy link
Contributor

…lues

PR Description

  • Modified faculty_list and student_list tables to use VARCHAR(255) for avatar column instead of TEXT.

  • Ensured compatibility with MySQL/MariaDB constraints regarding default values for BLOB/TEXT columns.

Problem
Screenshot (32)_LI

Problem Solved
Screenshot (31)_LI

Related Issues: Issue for which you are raising a PR for

Issue

#32

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • Is this a bug fix/enhancement/documentation changes
  • Part of GSSOC
  • Tested for any breaking changes
  • Other relevant checks completed

Undertaking

I declare that:

  1. The content I am submitting is original and has not been plagiarized.
  2. No portion of the work has been copied from any other source without proper attribution.
  3. The work has been checked for plagiarism, and I assure its authenticity.

I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.

  • I Agree

…lues

- Modified `faculty_list` and `student_list` tables to use VARCHAR(255) for `avatar` column instead of TEXT.

- Ensured compatibility with MySQL/MariaDB constraints regarding default values for BLOB/TEXT columns.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

Copy link
Collaborator

@aswinikalyan30 aswinikalyan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the one for users table too. Otherwise looks good 💯

@Swapnilden
Copy link
Contributor Author

Okay

change TEXT to VARCHAR for avatar column in users table
Copy link
Contributor Author

@Swapnilden Swapnilden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done it

Copy link
Collaborator

@aswinikalyan30 aswinikalyan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@aswinikalyan30 aswinikalyan30 merged commit 4cd12f6 into SaiyamTuteja:main May 20, 2024
1 check passed
@aswinikalyan30 aswinikalyan30 added gssoc Contribution to GSSoC '24 level2 Enhancements/ bugs of medium complexity level1 Easy solutions and removed level2 Enhancements/ bugs of medium complexity labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Contribution to GSSoC '24 level1 Easy solutions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Not able to run evaluation_db queries - value of Avatar cannot be set to null
2 participants