Feat: Filter genuine email #21 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aswinikalyan30 Any Update on my PR |
|
Hey. This has changes that solves an issue not assigned to you |
aswinikalyan30
approved these changes
May 23, 2024
| <div class="input-group-append"> | ||
| <div class="input-group-text"> | ||
| <span class="fas fa-lock" onclick="togglePasswordVisibility()"></span> | ||
| <span class="fas fa-eye" style="display:none;" onclick="togglePasswordVisibility()"></span> |
There was a problem hiding this comment.
The toggleVisibility is already being worked on by someone else
aswinikalyan30
added
enhancement
|
@aswinikalyan30 so what should i do?? should i update and pr again or i should close it. |
|
@SaiyamTuteja Can you merge my PR as it is approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Integrated disify api for filtering out disposable email by verify_email
Removed data redundancy by implementing cuid to be assigned to only one person
changes need to be done in SQL is to make CUID as primary key and remove index as primary key
Related Issues: Issue for which you are raising a PR for
Issue #21
[Issue number or description]
Checklist
mainbranch before making this PRUndertaking
I declare that:
I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.