Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Contact Us Page #56

Merged
merged 8 commits into from
Jun 1, 2024
Merged

Conversation

mahek0620
Copy link
Contributor

@mahek0620 mahek0620 commented May 27, 2024

Issue No #54 - Implementatio of Contact Us Page
And #52
Screenshot 2024-05-27 224418

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@aswinikalyan30
Copy link
Collaborator

@mahek0620 can you link all the issues you are solving here?
Also add screenshots for all changes made?

@mahek0620
Copy link
Contributor Author

I have already uploaded screenshot above.
Clicking the 'Contact Us' button will open a new page containing contact details such as phone number, email, and address, along with an attached form to fill the details. It allows users to offer feedback on the system, which can be valuable for making improvements and addressing user concerns. Users can report any technical problems they encounter, ensuring that issues are documented and can be resolved efficiently. It provides a direct channel for users, such as faculty members, students, and administrators, to seek assistance or report issues.
Note: For adding the social media links, a footer should be made on the website and social media links should be shared there instead of sharing in the Contact Us button. I will open a new issue and will fix that issue if you agree.

@aswinikalyan30
Copy link
Collaborator

Yes, I do understand that, I wanted you to add it for the reset email and password that you had implemented. Which is linked to another issue

@mahek0620
Copy link
Contributor Author

image
image
Here is the screenshot of login page with Forgot Password option

@aswinikalyan30
Copy link
Collaborator

Looks like the logo is missing
Could you add it back? Styles are changed drastically from what it was previously. If you are changing the theme - then it should be done for signup to maintain consistency.

@aswinikalyan30
Copy link
Collaborator

In issue #52 you mentioned you will implement a "sign in with google" button - Is that also added on this PR itself?

@mahek0620
Copy link
Contributor Author

@aswinikalyan30 Thank you for your feedback. I will surely add the logo

@mahek0620
Copy link
Contributor Author

can you please assign signin with google to one more person as I am facing difficulties in doing that

@aswinikalyan30
Copy link
Collaborator

Sure, will update that issue only for reset

@aswinikalyan30 aswinikalyan30 added gssoc Contribution to GSSoC '24 level3 Critical bugs/large enhancement of hard complexity labels May 28, 2024
@mahek0620
Copy link
Contributor Author

@aswinikalyan30 I have added logo in the contactUs page

Copy link
Collaborator

@aswinikalyan30 aswinikalyan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the login.php file , otherwise looks good!

login.php Outdated
</div>
<body>
<h1 id="page-title" class="text-center">Login Page</h1>
<hr id="title_hr" class="mx-auto">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add logo (from prev (line 51)

login.php Outdated
</div>
<div class="input-field">
<label for="password" class="input-label">Password</label>
<input type="password" id="password" name="password" value="<?= htmlspecialchars($_POST['password'] ?? "", ENT_QUOTES) ?>" required="required">
Copy link
Collaborator

@aswinikalyan30 aswinikalyan30 May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some code written by a prev contributor for toggle of password "fas fa-eye" - please don't scrape whatever was written before. I can see the different icons that were there are removed. It is okay to make additions to the file, this looks like its rebranded.

@mahek0620
Copy link
Contributor Author

@aswinikalyan30 can you please review it

@aswinikalyan30
Copy link
Collaborator

Sure.

Copy link
Collaborator

@aswinikalyan30 aswinikalyan30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@aswinikalyan30 aswinikalyan30 merged commit 9dfef77 into SaiyamTuteja:main Jun 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Contribution to GSSoC '24 level3 Critical bugs/large enhancement of hard complexity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants