-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created Contact Us Page #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.
@mahek0620 can you link all the issues you are solving here? |
I have already uploaded screenshot above. |
Yes, I do understand that, I wanted you to add it for the reset email and password that you had implemented. Which is linked to another issue |
Looks like the logo is missing |
In issue #52 you mentioned you will implement a "sign in with google" button - Is that also added on this PR itself? |
@aswinikalyan30 Thank you for your feedback. I will surely add the logo |
can you please assign signin with google to one more person as I am facing difficulties in doing that |
Sure, will update that issue only for reset |
@aswinikalyan30 I have added logo in the contactUs page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the login.php file , otherwise looks good!
login.php
Outdated
</div> | ||
<body> | ||
<h1 id="page-title" class="text-center">Login Page</h1> | ||
<hr id="title_hr" class="mx-auto"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add logo (from prev (line 51)
login.php
Outdated
</div> | ||
<div class="input-field"> | ||
<label for="password" class="input-label">Password</label> | ||
<input type="password" id="password" name="password" value="<?= htmlspecialchars($_POST['password'] ?? "", ENT_QUOTES) ?>" required="required"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some code written by a prev contributor for toggle of password "fas fa-eye" - please don't scrape whatever was written before. I can see the different icons that were there are removed. It is okay to make additions to the file, this looks like its rebranded.
@aswinikalyan30 can you please review it |
Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Issue No #54 - Implementatio of Contact Us Page
And #52