Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/slm 10 #13

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Task/slm 10 #13

wants to merge 10 commits into from

Conversation

yossef-khaled
Copy link
Collaborator

No description provided.


return (
<div style={{marginTop: '8rem', marginBottom: '5rem' ,display: 'flex', flexDirection: 'column', alignItems: 'center'}}>
<Image style={{width: '30%', minWidth: '280px' }} src={displaiedUserDetails.photo.url}/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

displayedUserDetails typo and in subsequent lines

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops..

);

//Import default image
import testImage from '../../../Assets/SalamLogo.jpeg';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If test Image is the "fallback image or alt image can we rename it to be clearer?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I changed it.

}
}, [])

console.log(displaiedUserDetails);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also remove the console log 🙏

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants