Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDA] Allow Customers The Ability To Backfill Missing Affiliation on Existing Student Course Connection #1068
[EDA] Allow Customers The Ability To Backfill Missing Affiliation on Existing Student Course Connection #1068
Changes from 18 commits
31b5f71
aaefab6
887695c
2f07ff9
ea8ef28
9124b08
3c24537
f6cd940
131a50c
1dadd85
841f2b2
4ed9918
b699ade
a0dc81c
1e12322
fa4dab0
7063790
65c3201
5ce33f5
81c0901
0baa0e6
423abba
48ef1e8
b3a619b
18a1395
1d5f045
3e70c7e
08cafbf
e65d41f
f47aa37
efe039f
320f9c1
2876ce0
d85152d
43169a6
32a2450
fd13cee
205dc45
401d1c3
b92a59e
4dea574
841901f
a7e5dc7
8d8e543
dea6bac
cdf993b
203dbb6
dccbfa7
56c6761
328d028
9147e64
740b04e
7d53fbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be really cool and perhaps something for a future tech-debt item would be to be able to write this code once and have our triggerTDTM use it, as well as the BATCH process use it. Or at least parts of it. So something like a CourseEnrollmentService, etc. Don't have to do it now but definitely the types of things we should be thinking about. (Maybe the way we currently have it written wouldn't allows us to do it very easily. #ThinkingOutLoud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: the spacing looks wonky here as well.