Skip to content

Commit

Permalink
Additional Kondo Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
lparrott committed Jan 3, 2025
1 parent 4d092d8 commit e66e565
Show file tree
Hide file tree
Showing 15 changed files with 35 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,12 @@
width: 100%;
padding: 0;
margin: 0;
border-radius: none;
padding-top: 0.25rem;
padding-bottom: 0.25rem;
border: none;
border-radius: var(--slds-g-radius-border-2, 0.25rem);
}

.slds-border_extension-bottom {
border-bottom: var(--slds-g-sizing-border-1, 1px) solid var(--slds-g-color-border-1, var(--lwc-colorBorder, rgb(221, 219, 218)));
border-radius: none;
}

.slds-button:disabled {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
width: 100%;
padding: 0;
margin: 0;
border-radius: none;
padding-top: 0.25rem;
padding-bottom: 0.25rem;
border: none;
Expand All @@ -49,5 +48,4 @@

.slds-border_extension-bottom {
border-bottom: var(--slds-g-sizing-border-1, 1px) solid var(--slds-g-color-border-1, var(--lwc-colorBorder, rgb(221, 219, 218)));
border-radius: none;
}
4 changes: 1 addition & 3 deletions force-app/main/default/lwc/geListView/geListView.css
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
}

.slds-page-header_extension {
background: var(--slds-g-color-surface-container-1, var(--lwc-colorBackgroundAlt, rgb(255, 255, 255)));
background: none;
border-bottom: var(--slds-g-sizing-border-1, 1px) solid var(--slds-g-color-neutral-base-90, var(--lwc-colorBorderSeparatorAlt, rgb(221, 219, 218)));
border-bottom-left-radius: none;
border-bottom-right-radius: none;
}
9 changes: 9 additions & 0 deletions force-app/main/default/lwc/geListView/geListView.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,15 @@ export default class geListView extends LightningElement {
});

this.isLoading = false;

console.log('Test 1');
let style = document.createElement('style');
style.innerText = '.slds-table_header-fixed_container{border: 1px solid red;}';
let dt = this.template.querySelector('lightning-datatable');
if(dt) {
dt.appendChild(style);
}
console.log('Test 2');
}

/*******************************************************************************
Expand Down
1 change: 0 additions & 1 deletion force-app/main/default/lwc/geModalPrompt/geModalPrompt.css
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
.slds-box_extension {
border: none;
border-radius: none;
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
.slds-box_extension {
border: none;
border-radius: none;
}
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
.slds-card_extension {
box-shadow: none var(--slds-g-sizing-border-2, 2px) var(--slds-g-sizing-border-2, 2px) none var(--slds-g-color-neutral-base-90, #ddd);
border: var(--slds-g-sizing-border-1, 1px) solid var(--slds-g-color-neutral-base-90, rgb(221, 219, 218));
}

.slds-card_extension-widget {
background-color: var(--slds-g-color-surface-3, #ECEBEA);
}

.vertical-align-center {
margin: auto 0;
}

.input-padding {
padding: 0 4px 4px 4px;
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<div class="slds-grid slds-grid_vertical-align-end">
<template if:false={isWidget}>
<div class="slds-size_5-of-12 slds-p-right_small">
<lightning-input class="slds-truncate"
<lightning-input class="slds-truncate input-padding"
data-name="customLabel"
field-level-help={labelHelpText}
label={field.label}
Expand Down Expand Up @@ -35,7 +35,7 @@
</c-util-input>
</template>
</div>
<div class="slds-size_1-of-12 slds-p-left_large slds-p-bottom_x-small">
<div class="slds-size_1-of-12 slds-p-left_large slds-p-bottom_small">
<template if:true={showRequiredCheckbox}>
<lightning-input aria-label={labelGeAssistiveRequireField}
aria-describedby="requiredCheckboxDescription"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export default class geTemplateBuilderFormField extends LightningElement {
if (this.field.elementType === WIDGET) {
return 'slds-size_1-of-12 vertical-align-center'
} else {
return 'slds-size_1-of-12 slds-p-bottom_x-small';
return 'slds-size_1-of-12 slds-p-bottom_small';
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
.slds-card_extension {
box-shadow: none var(--slds-g-sizing-border-2, 2px) var(--slds-g-sizing-border-2, 2px) none var(--slds-g-color-neutral-base-90, #ddd);
border: var(--slds-g-radius-border-1, 2px) solid var(--slds-g-color-neutral-base-90, rgb(221, 219, 218));
transition: box-shadow 0.3s cubic-bezier(.25,.8,.25,1);
}

.slds-card_extension:hover {
cursor: pointer;
box-shadow: none var(--slds-g-sizing-border-3, 3px) var(--slds-g-sizing-border-3, 3px) var(--slds-g-color-neutral-base-90, #ddd), none var(--slds-g-sizing-border-3, 3px) var(--slds-g-sizing-border-3, 3px) var(--slds-g-color-neutral-base-90, #ddd);
}

.slds-card_extension_active {
Expand All @@ -21,6 +18,7 @@
border: var(--slds-g-radius-border-4, 1rem) solid transparent;
border-right-color: var(--slds-g-color-brand-base-60, #1589ee);
border-top-color: var(--slds-g-color-brand-base-60, #1589ee);
border-top-right-radius: var(--slds-g-radius-border-2, 0.25rem);
}

.slds-icon_container_extension {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<lightning-layout>
<lightning-layout-item size="12" class="slds-p-left_small">
<lightning-layout-item size="12" class="slds-p-left_small slds-p-vertical_small">
<lightning-layout>
<template if:true={isAllocations}>
<lightning-layout-item size="12">
Expand Down
3 changes: 0 additions & 3 deletions force-app/main/default/lwc/geTemplates/geTemplates.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
.slds-card_extension {
background: var(--slds-g-color-disabled-container-1, #fff);
border: var(--slds-g-sizing-border-1, 1px) solid var(--slds-g-color-neutral-base-90, #dddbda);
border-radius: var(--slds-g-radius-border-2, .25rem);
background-clip: padding-box;
box-shadow: none var(--slds-g-sizing-border-2, 2px) var(--slds-g-sizing-border-2, 2px) none var(--slds-g-color-neutral-base-90, #ddd);
}
8 changes: 8 additions & 0 deletions force-app/main/default/lwc/utilInput/utilInput.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
.slds-form-element_hidden label {
display: none;
}

.input-padding {
padding-bottom: 4px;
}

.combo-adjust {
top: -4px;
}
13 changes: 7 additions & 6 deletions force-app/main/default/lwc/utilInput/utilInput.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<template if:false={isWidget}>
<template if:true={isLightningRichText}>
<lightning-input-rich-text aria-label="default value"
class="slds-p-horizontal_xx-small"
class="slds-p-horizontal_xx-small input-padding"
data-id='inputComponent'
data-name="defaultValue"
formats={richTextFormats}
Expand All @@ -30,7 +30,7 @@
data-id='inputComponent'
label={uiLabel}
required={isRequired}
class="slds-m-around_none"
class="slds-m-around_none input-padding"
data-name="defaultValue"
onfocusout={handleValueChange}
onclick={stopPropagation}
Expand All @@ -49,6 +49,7 @@
options={picklistValues}
data-qa-locator={qaLocatorPicklist}
required={isRequired}
class="combo-adjust"
variant={variant}>
</lightning-combobox>
</template>
Expand All @@ -59,7 +60,7 @@
label={uiLabel}
required={isRequired}
checked={fieldValue}
class="slds-m-top_small"
class="slds-m-top_small input-padding"
data-name="defaultValue"
onchange={handleValueChange}
onclick={stopPropagation}
Expand All @@ -82,7 +83,7 @@
onchange={handleValueChange}
required={isRequired}
variant='label-hidden'
class="help-text-hidden"
class="help-text-hidden input-padding"
value={fieldValue}
data-qa-locator={qaLocatorLookup}>
</lightning-input-field>
Expand All @@ -96,7 +97,7 @@
data-id='inputComponent'
label={uiLabel}
required={isRequired}
class="slds-m-around_none"
class="slds-m-around_none input-padding"
data-name="defaultValue"
onchange={handleValueChange}
onclick={stopPropagation}
Expand All @@ -113,7 +114,7 @@
data-id='inputComponent'
label={uiLabel}
required={isRequired}
class="slds-m-around_none"
class="slds-m-around_none input-padding"
data-name="defaultValue"
onfocusout={handleValueChange}
onclick={stopPropagation}
Expand Down
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/utilInput/utilInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export default class utilInput extends LightningElement {
} else if (this.variant === LABEL_STACKED) {
return 'slds-form-element slds-form-element_stacked';
} else if (this.variant === LABEL_HIDDEN) {
return 'slds-form-element slds-form-element_hidden';
return 'slds-form-element slds-form-element_hidden combo-adjust';
}
}

Expand Down

0 comments on commit e66e565

Please sign in to comment.