Update Next Recurring Donation Installment Amount #7086

lparrott · 2022-08-22T16:15:08Z

W-11556857
W-11556798

We've added back-end methods and a UI to update the Amount of the next Installment of a Recurring Donation
Test steps can be found in the Design Doc

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

…t Amount

…pdateInstallment

… made

…ortunity

…pdateInstallment

…for Elevate RDs

…alesforceFoundation/NPSP into feature/242__updateInstallment

lparrott · 2022-08-29T17:24:34Z

force-app/main/default/classes/RD2_RecurringDonation.cls

+    * @return Boolean True if the Next Payment Date has changed on an Elevate connected RD
+    */
+    public Boolean needsNextPaymentScheduleCheck() {
+        return changedFields.contains(npe03__Recurring_Donation__c.npe03__Next_Payment_Date__c)


Since RD2 disables the CRLP for this field, I think this is a safe way to "know" that a Payment has been Paid?

npsp-reedestockton · 2022-08-31T05:13:29Z

force-app/main/default/classes/PS_CommitmentRequest.cls

@@ -267,8 +267,11 @@ public inherited sharing class PS_CommitmentRequest {
            : UserInfo.getDefaultCurrency();

        if (isElevateScheduleFieldsChanged(rd, oldRd)) {
+            // If the schedule has a Next Payment Amount, we need to send it
+            List<RecurringDonationSchedule__c> rdSchedules = scheduleService.getExistingSchedules(rd);
+            Decimal nextPaymentAmount = rdSchedules.size() > 0 ? rdSchedules[0].NextPaymentAmount__c : null;


I'd be happier if we didn't have any implementation details in this class. Maybe getNextPaymentAmount in RD2_ScheduleService??

Also, is it safe to assume the amount is on the first active schedule? Will it be on both schedules for a 1st and 15th cadence?

I didn't realize 1st and 15th used 2 Active schedules, I'll double check that they're in the correct sort order. I can create that method, good suggestion.

npsp-reedestockton · 2022-08-31T05:21:43Z

force-app/main/default/classes/RD2_ScheduleService.cls

@@ -95,6 +106,9 @@ public without sharing class RD2_ScheduleService {
        schedule.Campaign__c = rd.npe03__Recurring_Donation_Campaign__c;

        schedule.InstallmentAmount__c = rd.npe03__Amount__c;
+        if(nextPaymentAmount != null) {


I think we end up with nextPaymentAmount on both schedules for a 1st and 15th cadence. Is that what we want?

Nope, we should only set it on the schedule that represents the next payment, I'll update this.

On second thought, this shouldn't hurt anything as long as we clear both of them after the one-time payment is paid. Makes the logic a bit cleaner, no need to figure out which schedule to set 🤷

npsp-reedestockton · 2022-08-31T05:27:09Z

force-app/main/default/classes/RD2_ScheduleService.cls

@@ -187,6 +203,7 @@ public without sharing class RD2_ScheduleService {
        List<RecurringDonationSchedule__c> newSchedules = buildNewSchedules(rd);
        for (RecurringDonationSchedule__c newSchedule : newSchedules) {
            newSchedule.StartDate__c = newStartDate;
+            newSchedule.NextPaymentAmount__c = nextPaymentAmount;


What's the reason for putting nextPaymentAmount on more than one schedule record?

No reason, in my testing this was always a single schedule, but I didn't account for 1st and 15th. Are there other scenarios where there will be more than 1 new schedule created?

I believe that right now that's the only time we create more than one.

There can be multiple active schedules: 2 current if it's a 1st and 15th schedule + 2 future if the future schedule is a 1st and 15th + pause schedule. Currently, five active would be the cap I think, but there's no structural reason we would be prohibited from having more future schedules or more current schedules. Unlikely we'll do either of those things, but you never know.

I'm refactoring this a bit, but I'm still going to set NextPaymentAmount on all new Schedules. It shouldn't hurt anything if we clear them all after that Payment is paid.

…pdateInstallment # Conflicts: # force-app/main/default/classes/RD2_EntryFormController.cls

andrewyu-salesforce · 2022-08-31T17:43:30Z

force-app/main/default/classes/RD2_EntryFormController.cls

+        * @param nextPaymentAmount The Next Payment Amount to set on the Schedule
+        * @return UTIL_Http.Response Payments API response
+        */
+        public UTIL_Http.Response handleNextPaymentAmount(npe03__Recurring_Donation__c rd, Decimal nextPaymentAmount) {


Are we planning to reuse the same controller class as the RD2 Entry form or this is just a placeholder until the new UI/Controller is created

I was thinking I'd use the same Class since it has everything we need. Technically it's a type of RD Entry?

andrewyu-salesforce · 2022-08-31T17:58:50Z

force-app/main/default/classes/RD2_OpportunityEvaluationService.cls

@@ -445,16 +447,27 @@ public inherited sharing class RD2_OpportunityEvaluationService {
            }
            else {
                if (isNewOpportunityCandidate(rdRecord)) {
+                    // Prevent the Next Payment Amount from being used in later steps of this process
+                    rd.RecurringDonationSchedules__r[0].NextPaymentAmount__c = null;


Will this chunk of code be unnecessary because NextPaymentAmount__c will not be set on new RD?

This is actually where I'm clearing NextPaymentAmount for non-Elevate RDs. My assumption is that if isNewOpportunityCandidate is true, a Payment has been made, which should have used the NextPaymentAmount, meaning we can now clear it.

andrewyu-salesforce · 2022-08-31T18:15:59Z

force-app/main/default/classes/RD2_RecurringDonation.cls

+    */
+    public Boolean needsNextPaymentScheduleCheck() {
+        return changedFields.contains(npe03__Recurring_Donation__c.npe03__Next_Payment_Date__c)
+            && isElevateRecord();


Is there a reason we aren't clearing the next payment amount for non-elevate RD?

Since isNewOpportunityCandidate won't happen for Elevate RDs, I needed a different way to clear them. I'm unsure if this will work though, still need to do E2E testing.

…Next Payment Amount, update to Installment UI

andrewyu-salesforce

Looks good

npsp-reedestockton

Looks good!

lparrott and others added 12 commits August 16, 2022 16:13

Initial commit of Update Single RD Installment work

67cbf8a

RD Single Installment: Updating next Opportunity to match Next Paymen…

b9f784a

…t Amount

Merge remote-tracking branch 'origin/feature/242' into feature/242__u…

f7184fa

…pdateInstallment

Clearing the Next Payment Amount field on Schedule after a Payment is…

99be419

… made

Clear the Next Payment Amount on RD Schedules when creating a new Opp…

ac9bec9

…ortunity

Merge remote-tracking branch 'origin/feature/242' into feature/242__u…

d89a008

…pdateInstallment

Adding methods to send Next Payment Amount to Elevate Schedule

81fe216

Merge remote-tracking branch 'origin/feature/242' into feature/242__u…

1a88269

…pdateInstallment

Merge fdd36c8 into feature/242__updateInstallment

273649b

Fixing Next Payment Amount scenarios, sending and clearing the value …

c946150

…for Elevate RDs

Merge branch 'feature/242__updateInstallment' of https://github.com/S…

aef81be

…alesforceFoundation/NPSP into feature/242__updateInstallment

Merge ce70b3e into feature/242__updateInstallment

b190f44

lparrott commented Aug 29, 2022

View reviewed changes

Update Single RD Installment: fixing unit tests

6a1e3ca

lparrott added the Do Not Merge label Aug 29, 2022

lparrott requested a review from andrewyu-salesforce August 29, 2022 21:11

npsp-reedestockton assigned npsp-reedestockton and unassigned npsp-reedestockton Aug 30, 2022

npsp-reedestockton self-requested a review August 30, 2022 02:16

npsp-reedestockton reviewed Aug 31, 2022

View reviewed changes

Merge remote-tracking branch 'origin/feature/242' into feature/242__u…

5cf4618

…pdateInstallment # Conflicts: # force-app/main/default/classes/RD2_EntryFormController.cls

andrewyu-salesforce reviewed Aug 31, 2022

View reviewed changes

lparrott added 3 commits August 31, 2022 14:19

Update Single RD Installment PR feedback

91f8f6c

RD Single Installment, fixing scenario where multiple schedules have …

ebab0b9

…Next Payment Amount, update to Installment UI

Initial commit of Update Single Installment UI

e6c03f4

lparrott requested review from npsp-reedestockton and andrewyu-salesforce September 6, 2022 20:56

andrewyu-salesforce approved these changes Sep 6, 2022

View reviewed changes

npsp-reedestockton approved these changes Sep 7, 2022

View reviewed changes

Merge 6901cfc into feature/242__updateInstallment

2a2653e

salesforce-org-metaci bot added 27 commits November 9, 2022 21:51

Merge d357dcc into feature/242__updateInstallment

6dc0111

Merge 3127098 into feature/242__updateInstallment

19fd9b7

Merge 8632f24 into feature/242__updateInstallment

afed30f

Merge 753f434 into feature/242__updateInstallment

11395f0

Merge 7e56d00 into feature/242__updateInstallment

f99ae24

Merge 15858f0 into feature/242__updateInstallment

c425c60

Merge 974c86c into feature/242__updateInstallment

6593aeb

Merge a35f1fd into feature/242__updateInstallment

4176d8f

Merge fdf146d into feature/242__updateInstallment

f0a7832

Merge 08902d4 into feature/242__updateInstallment

a42f6f5

Merge f78f521 into feature/242__updateInstallment

2a056b7

Merge e02dd7f into feature/242__updateInstallment

96ddaa3

Merge 87303b9 into feature/242__updateInstallment

52ae757

Merge e656dc8 into feature/242__updateInstallment

a0c3d92

Merge 1c4b65c into feature/242__updateInstallment

52e6454

Merge cded394 into feature/242__updateInstallment

a816b40

Merge c3e64a4 into feature/242__updateInstallment

1a44e97

Merge 653098f into feature/242__updateInstallment

be38407

Merge a3a8218 into feature/242__updateInstallment

40c5df8

Merge f224cde into feature/242__updateInstallment

33d0919

Merge 653258e into feature/242__updateInstallment

30839c4

Merge c34c6c0 into feature/242__updateInstallment

6c2f506

Merge a3e469b into feature/242__updateInstallment

1fd3f83

Merge 0058505 into feature/242__updateInstallment

2727554

Merge 0f76cb3 into feature/242__updateInstallment

dfc1533

Merge 2ca2abc into feature/242__updateInstallment

cb82943

Merge d115ac2 into feature/242__updateInstallment

16a3f50

lparrott deleted the branch feature/242 December 4, 2024 20:35

lparrott closed this Dec 4, 2024

lparrott deleted the feature/242__updateInstallment branch December 4, 2024 20:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Next Recurring Donation Installment Amount #7086

Update Next Recurring Donation Installment Amount #7086

lparrott commented Aug 22, 2022 •

edited

Loading

lparrott Aug 29, 2022

npsp-reedestockton Aug 31, 2022 •

edited

Loading

lparrott Aug 31, 2022

npsp-reedestockton Aug 31, 2022

lparrott Aug 31, 2022

lparrott Aug 31, 2022

npsp-reedestockton Aug 31, 2022

lparrott Aug 31, 2022

npsp-reedestockton Aug 31, 2022

lparrott Aug 31, 2022

andrewyu-salesforce Aug 31, 2022

lparrott Aug 31, 2022

andrewyu-salesforce Aug 31, 2022

lparrott Aug 31, 2022

andrewyu-salesforce Aug 31, 2022

lparrott Aug 31, 2022

andrewyu-salesforce left a comment

npsp-reedestockton left a comment

Update Next Recurring Donation Installment Amount #7086

Update Next Recurring Donation Installment Amount #7086

Conversation

lparrott commented Aug 22, 2022 • edited Loading

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

Choose a reason for hiding this comment

npsp-reedestockton Aug 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewyu-salesforce left a comment

Choose a reason for hiding this comment

npsp-reedestockton left a comment

Choose a reason for hiding this comment

lparrott commented Aug 22, 2022 •

edited

Loading

npsp-reedestockton Aug 31, 2022 •

edited

Loading